Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 465983003: Delete PrintContext::spoolAllPagesWithBoundaries (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
CC:
blink-reviews, skobes
Project:
blink
Visibility:
Public.

Description

Delete PrintContext::spoolAllPagesWithBoundaries This code is dead. This CL also removes a bunch of other related dead code. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180112

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M Source/core/page/PrintContext.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/page/PrintContext.cpp View 2 chunks +0 lines, -64 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +0 lines, -15 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-12 20:42:05 UTC) #1
esprehn
lgtm
6 years, 4 months ago (2014-08-12 20:47:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/465983003/1
6 years, 4 months ago (2014-08-12 20:47:55 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 22:17:00 UTC) #4
commit-bot: I haz the power
Change committed as 180112
6 years, 4 months ago (2014-08-12 22:54:38 UTC) #5
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-13 19:37:08 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/465983003/diff/1/Source/web/WebLocalFrameImpl...
File Source/web/WebLocalFrameImpl.cpp (left):

https://codereview.chromium.org/465983003/diff/1/Source/web/WebLocalFrameImpl...
Source/web/WebLocalFrameImpl.cpp:307: PrintContext::end();
it's incorrect to remove this calls
base class has no virtual

Example:
ChromePrintContext* context = new ChromePluginPrintContext()
context->end()  // PrintContext::end() is called, not
ChromePluginPrintContext::end()

https://codereview.chromium.org/465983003/diff/1/Source/web/WebLocalFrameImpl...
Source/web/WebLocalFrameImpl.cpp:385: {
same

Powered by Google App Engine
This is Rietveld 408576698