Issue 465973002: Fix lower-casing error in font config parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465973002: Fix lower-casing error in font config parser (Closed)

Created:
6 years, 4 months ago by Tom Hudson

Modified:
6 years, 4 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org, djsollen

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Fix lower-casing error in font config parser The Android font config parser was missing some SkAutoAsciiToLC instantiations; this was discovered in https://crrev.com/458543002/ but should land independently. BUG=chromium:400801 R=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/b3d4af512e9d60019790cf42701ac62edb3f5b00

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/ports/SkFontConfigParser_android.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

tomhudson

PTAL; we should land this before we turn on the fontmgr before we start reading ...

6 years, 4 months ago (2014-08-12 14:25:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/465973002/1

6 years, 4 months ago (2014-08-12 14:30:28 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-12 14:42:22 UTC) #4

Message was sent while issue was closed.

Change committed as b3d4af512e9d60019790cf42701ac62edb3f5b00