Issue 465863002: Revert of Fix leaks when the shared worker is requested to be terminated while loading the main script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465863002: Revert of Fix leaks when the shared worker is requested to be terminated while loading the main script. (Closed)

Created:
6 years, 4 months ago by horo

Modified:
6 years, 4 months ago

Reviewers:
sof, jochen (gone - plz use gerrit)

CC:
blink-reviews, kouhei (in TOK)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Fix leaks when the shared worker is requested to be terminated while loading the main script. (https://codereview.chromium.org/451603002/) Reason for revert: UAF bug in WebSharedWorkerImpl::stopWorkerThread(). Original issue's description: > Fix leaks when the shared worker is requested to be terminated while loading the main script. > > BUG=398742 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180013 TBR=jochen@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=398742 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180031

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	LayoutTests/LeakExpectations	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	Source/web/WebSharedWorkerImpl.cpp	View		2 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 1 (0 generated)

horo

6 years, 4 months ago (2014-08-12 05:42:25 UTC) #1

Created Revert of Fix leaks when the shared worker is requested to be terminated
while loading the main script.