Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: cc/test/layer_tree_host_common_test.h

Issue 465853004: Moving RenderSurface creation outside of CalcDrawProps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated unit tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/layer_tree_host_common_test.h
diff --git a/cc/test/layer_tree_host_common_test.h b/cc/test/layer_tree_host_common_test.h
index 67eb6cc58b3da0af29b229a57c1154352fc5c0ef..c5044b1ee74b482c6b5ba3c4ab3c59b12ee06cba 100644
--- a/cc/test/layer_tree_host_common_test.h
+++ b/cc/test/layer_tree_host_common_test.h
@@ -37,13 +37,17 @@ class LayerTreeHostCommonTestBase {
const gfx::PointF& position,
const gfx::Size& bounds,
bool flatten_transform,
- bool is_3d_sorted) {
+ bool is_3d_sorted,
+ bool create_render_surface) {
layer->SetTransform(transform);
layer->SetTransformOrigin(transform_origin);
layer->SetPosition(position);
layer->SetBounds(bounds);
layer->SetShouldFlattenTransform(flatten_transform);
layer->Set3dSortingContextId(is_3d_sorted ? 1 : 0);
+ if (create_render_surface) {
+ layer->CreateRenderSurface();
+ }
}
void SetLayerPropertiesForTesting(Layer* layer,
@@ -60,7 +64,8 @@ class LayerTreeHostCommonTestBase {
const gfx::PointF& position,
const gfx::Size& bounds,
bool flatten_transform,
- bool is_3d_sorted);
+ bool is_3d_sorted,
+ bool create_render_surface = false);
danakj 2014/08/26 18:06:13 no default parameters please. this violates the st
awoloszyn 2014/08/28 19:31:43 Done.
void ExecuteCalculateDrawProperties(Layer* root_layer,
float device_scale_factor,

Powered by Google App Engine
This is Rietveld 408576698