cc/layers/render_surface_unittest.cc - Issue 465853004: Moving RenderSurface creation outside of CalcDrawProps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/render_surface_unittest.cc

Issue 465853004: Moving RenderSurface creation outside of CalcDrawProps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/layers/layer_impl.cc ('K') | « cc/layers/render_surface_impl_unittest.cc ('k') | cc/layers/solid_color_layer_impl_unittest.cc » ('j') | ui/compositor/transform_animation_curve_adapter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/layers/render_surface_unittest.cc

diff --git a/cc/layers/render_surface_unittest.cc b/cc/layers/render_surface_unittest.cc

index 8175efa33e2a93aca2f05615a8899f183cd7588d..30e12032322083726dbf269cb22aa6f29d6a80a1 100644

--- a/cc/layers/render_surface_unittest.cc

+++ b/cc/layers/render_surface_unittest.cc

@@ -41,7 +41,7 @@ TEST(RenderSurfaceTest, VerifySurfaceChangesAreTrackedProperly) {

FakeLayerTreeHostImpl host_impl(&proxy, &shared_bitmap_manager);

scoped_ptr<LayerImpl> owning_layer =

LayerImpl::Create(host_impl.active_tree(), 1);

- owning_layer->CreateRenderSurface();

+ owning_layer->SetHasRenderSurface(true);

ASSERT_TRUE(owning_layer->render_surface());

RenderSurfaceImpl* render_surface = owning_layer->render_surface();

gfx::Rect test_rect(3, 4, 5, 6);

@@ -89,7 +89,7 @@ TEST(RenderSurfaceTest, SanityCheckSurfaceCreatesCorrectSharedQuadState) {

scoped_ptr<LayerImpl> owning_layer =

LayerImpl::Create(host_impl.active_tree(), 2);

- owning_layer->CreateRenderSurface();

+ owning_layer->SetHasRenderSurface(true);

ASSERT_TRUE(owning_layer->render_surface());

owning_layer->draw_properties().render_target = owning_layer.get();

@@ -160,7 +160,7 @@ TEST(RenderSurfaceTest, SanityCheckSurfaceCreatesCorrectRenderPass) {

scoped_ptr<LayerImpl> owning_layer =

LayerImpl::Create(host_impl.active_tree(), 2);

- owning_layer->CreateRenderSurface();

+ owning_layer->SetHasRenderSurface(true);

ASSERT_TRUE(owning_layer->render_surface());

owning_layer->draw_properties().render_target = owning_layer.get();

RenderSurfaceImpl* render_surface = owning_layer->render_surface();