cc/layers/picture_layer_impl_unittest.cc - Issue 465853004: Moving RenderSurface creation outside of CalcDrawProps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 465853004: Moving RenderSurface creation outside of CalcDrawProps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/layers/layer_impl.cc ('K') | « cc/layers/nine_patch_layer_impl_unittest.cc ('k') | cc/layers/render_surface_impl_unittest.cc » ('j') | ui/compositor/transform_animation_curve_adapter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/layers/picture_layer_impl_unittest.cc

diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc

index d18e97a553baaf9bf7e99432f33a2e7d80615918..9564a7baf2c6541bc20c92deb0c72380840765da 100644

--- a/cc/layers/picture_layer_impl_unittest.cc

+++ b/cc/layers/picture_layer_impl_unittest.cc

@@ -150,6 +150,7 @@ class PictureLayerImplTest : public testing::Test {

pending_layer = FakePictureLayerImpl::CreateWithRasterSource(

pending_tree, id_, raster_source);

pending_layer->SetDrawsContent(true);

+ pending_layer->SetHasRenderSurface(true);

}

// The bounds() just mirror the pile size.

pending_layer->SetBounds(pending_layer->raster_source()->GetSize());

@@ -3741,6 +3742,7 @@ TEST_F(PictureLayerImplTest, UpdateTilesForMasksWithNoVisibleContent) {

FakePictureLayerImpl* pending_mask_content = mask.get();

layer_with_mask->SetMaskLayer(mask.Pass());

+ layer_with_mask->SetHasRenderSurface(true);

scoped_ptr<FakePictureLayerImpl> child_of_layer_with_mask =

FakePictureLayerImpl::Create(host_impl_.pending_tree(), 4);

@@ -3752,6 +3754,7 @@ TEST_F(PictureLayerImplTest, UpdateTilesForMasksWithNoVisibleContent) {

layer_with_mask->AddChild(child_of_layer_with_mask.Pass());

root->AddChild(layer_with_mask.Pass());

+ root->SetHasRenderSurface(true);

host_impl_.pending_tree()->SetRootLayer(root.Pass());