cc/layers/solid_color_layer_impl_unittest.cc - Issue 465853004: Moving RenderSurface creation outside of CalcDrawProps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/solid_color_layer_impl_unittest.cc

Issue 465853004: Moving RenderSurface creation outside of CalcDrawProps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/solid_color_layer_impl_unittest.cc

diff --git a/cc/layers/solid_color_layer_impl_unittest.cc b/cc/layers/solid_color_layer_impl_unittest.cc

index 1720ce9a2ab460935d77628277e72ef197db233a..c772387c44ade1bd3540e7460b087cc942e7066a 100644

--- a/cc/layers/solid_color_layer_impl_unittest.cc

+++ b/cc/layers/solid_color_layer_impl_unittest.cc

@@ -35,7 +35,7 @@ TEST(SolidColorLayerImplTest, VerifyTilingCompleteAndNoOverlap) {

layer->draw_properties().visible_content_rect = visible_content_rect;

layer->SetBounds(layer_size);

layer->SetContentBounds(layer_size);

- layer->CreateRenderSurface();

+ layer->SetHasRenderSurface(true);

layer->draw_properties().render_target = layer.get();

AppendQuadsData data;

@@ -63,7 +63,7 @@ TEST(SolidColorLayerImplTest, VerifyCorrectBackgroundColorInQuad) {

layer->SetBounds(layer_size);

layer->SetContentBounds(layer_size);

layer->SetBackgroundColor(test_color);

- layer->CreateRenderSurface();

+ layer->SetHasRenderSurface(true);

layer->draw_properties().render_target = layer.get();

AppendQuadsData data;

@@ -92,7 +92,7 @@ TEST(SolidColorLayerImplTest, VerifyCorrectOpacityInQuad) {

layer->SetBounds(layer_size);

layer->SetContentBounds(layer_size);

layer->draw_properties().opacity = opacity;

- layer->CreateRenderSurface();

+ layer->SetHasRenderSurface(true);

layer->draw_properties().render_target = layer.get();

AppendQuadsData data;

« cc/layers/picture_layer_impl_unittest.cc ('K') | « cc/layers/render_surface_unittest.cc ('k') | cc/layers/tiled_layer_impl_unittest.cc » ('j') | cc/layers/tiled_layer_unittest.cc » ('J')