Moving RenderSurface creation outside of CalcDrawProps

cc/trees/layer_tree_host_impl.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TREES_LAYER_TREE_HOST_IMPL_H_
 #define CC_TREES_LAYER_TREE_HOST_IMPL_H_
 
 #include <list>
 #include <set>
 #include <string>
@@ skipping 167 matching lines @@
 
     // RenderPassSink implementation.
     virtual void AppendRenderPass(scoped_ptr<RenderPass> render_pass) OVERRIDE;
   };
 
   virtual void BeginMainFrameAborted(bool did_handle);
   virtual void BeginCommit();
   virtual void CommitComplete();
   virtual void Animate(base::TimeTicks monotonic_time);
   virtual void UpdateAnimationState(bool start_ready_animations);
+  virtual bool IsTesting();

[awoloszyn, 2014/08/14 17:37:27]

This is used to trigger RenderSurface creation on impl-side, because many of our
unit-tests create only the impl-side version of the tree. I tried with templates
to hide some of this, and only made it much worse. The only other thing I can
think of is creating a virtual that we call into before CDP, with a null default
behavior, and the render-surface creation for testing. (If preferred I can
change to that).

[danakj, 2014/08/14 17:44:20]

Oh gosh. Maybe we need to be refactoring our unit tests before we attempt this,
because leaking unit test problems into production code sounds like bad times.

Maybe (some of?) those tests that directly make impl things should be making
main thread things instead.

This is a huge conceptual change in the compositor and a lot of our tests have
assumptions built in which are breaking now, or will break in the future as we
rewrite the world. We need to consider how we can make those tests reflect the
real world not some past one with bandaids.

How can we fix our tests to not need this?

   void ActivateAnimations();
   void MainThreadHasStoppedFlinging();
   void UpdateBackgroundAnimateTicking(bool should_background_tick);
   void DidAnimateScrollOffset();
   void SetViewportDamage(const gfx::Rect& damage_rect);
 
   virtual void ManageTiles();
 
   // Returns DRAW_SUCCESS unless problems occured preparing the frame, and we
   // should try to avoid displaying the frame. If PrepareToDraw is called,
@@ skipping 523 matching lines @@
 
   std::vector<PictureLayerImpl*> picture_layers_;
   std::vector<PictureLayerImpl::Pair> picture_layer_pairs_;
 
   DISALLOW_COPY_AND_ASSIGN(LayerTreeHostImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_TREES_LAYER_TREE_HOST_IMPL_H_