pkg/analysis_services/lib/src/completion/local_computer.dart - Issue 465843002: respect show/hide combinators when generating suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_services/lib/src/completion/local_computer.dart

Issue 465843002: respect show/hide combinators when generating suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_services/lib/src/completion/imported_type_computer.dart ('K') | « pkg/analysis_services/lib/src/completion/imported_type_computer.dart ('k') | pkg/analysis_services/test/completion/completion_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_services/lib/src/completion/local_computer.dart

diff --git a/pkg/analysis_services/lib/src/completion/local_computer.dart b/pkg/analysis_services/lib/src/completion/local_computer.dart

index a17b066a618f174c92c72efad4d2a998fbf67b36..a9cd972fefa7da150e2098db60a97ed1a373932f 100644

--- a/pkg/analysis_services/lib/src/completion/local_computer.dart

+++ b/pkg/analysis_services/lib/src/completion/local_computer.dart

@@ -17,12 +17,11 @@ import 'package:analyzer/src/generated/ast.dart';

class LocalComputer extends CompletionComputer {

@override

- bool computeFast(CompilationUnit unit,

+ bool computeFast(CompilationUnit unit, AstNode node,

List<CompletionSuggestion> suggestions) {

// Find the specific child [AstNode] that contains the completion offset

// and collect suggestions starting with that node

- AstNode node = new NodeLocator.con1(offset).searchWithin(unit);

if (node != null) {

node.accept(new _LocalVisitor(offset, suggestions));

}

@@ -35,7 +34,7 @@ class LocalComputer extends CompletionComputer {

}

@override

- Future<bool> computeFull(CompilationUnit unit,

+ Future<bool> computeFull(CompilationUnit unit, AstNode node,

List<CompletionSuggestion> suggestions) {

// TODO: implement computeFull

// include results from part files that are included in the library