Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 465833003: Fix failing EME layout test. (Closed)

Created:
6 years, 4 months ago by jrummell
Modified:
6 years, 4 months ago
Reviewers:
xhwang, ddorwin
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix EME layout test as PromiseResolver objects no longer linger. A recent CL (Blink revision 179922) changed the way JavaScript is run after resolving a promise (used to run immediately, now run by a microtask later). encrypted-media-lifetime-mediakeysession-reference.html started failing as it expected the PromiseResolver object to be around and counted. Fixing the test as the PromiseResolver object is gone by the time the JavaScript executes after resolving a promise. BUG=374772, 378245 TEST=failing test passes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html View 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jrummell
PTAL. Has been failing in the flakiness dashboard since yesterday morning.
6 years, 4 months ago (2014-08-12 21:49:56 UTC) #1
ddorwin
Thanks. Please mention the specific CL in the description and update the first line to ...
6 years, 4 months ago (2014-08-12 22:13:10 UTC) #2
jrummell
The CQ bit was checked by jrummell@chromium.org
6 years, 4 months ago (2014-08-12 22:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/465833003/1
6 years, 4 months ago (2014-08-12 22:38:57 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 23:37:31 UTC) #5
Message was sent while issue was closed.
Change committed as 180121

Powered by Google App Engine
This is Rietveld 408576698