Download webstore CRXs into separate directory.

chrome/browser/extensions/webstore_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_installer.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
+#include "base/metrics/field_trial.h"
+#include "base/path_service.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/download/download_stats.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/install_tracker.h"
 #include "chrome/browser/extensions/install_tracker_factory.h"
 #include "chrome/browser/extensions/install_verifier.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/manifest_handlers/shared_module_info.h"
 #include "chrome/common/omaha_query_params/omaha_query_params.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/browser/download_url_parameters.h"
 #include "content/public/browser/navigation_controller.h"
@@ skipping 27 matching lines @@
 
 const char kInvalidIdError[] = "Invalid id";
 const char kDownloadDirectoryError[] = "Could not create download directory";
 const char kDownloadCanceledError[] = "Download canceled";
 const char kInstallCanceledError[] = "Install canceled";
 const char kDownloadInterruptedError[] = "Download interrupted";
 const char kInvalidDownloadError[] =
     "Download was not a valid extension or user script";
 const char kDependencyNotFoundError[] = "Dependency not found";
 const char kDependencyNotSharedModuleError[] =
-  "Dependency is not shared module";
+    "Dependency is not shared module";
 const char kInlineInstallSource[] = "inline";
 const char kDefaultInstallSource[] = "ondemand";
 const char kAppLauncherInstallSource[] = "applauncher";
 
+// Folder for downloading crx files from the webstore. This is used so that the
+// crx files don't go via the usual downloads folder.
+const base::FilePath::CharType kWebstoreDownloadFolder[] =
+    FILE_PATH_LITERAL("Webstore Downloads");
+
 base::FilePath* g_download_directory_for_tests = NULL;
 
 // Must be executed on the FILE thread.
 void GetDownloadFilePath(
-    const base::FilePath& download_directory, const std::string& id,
+    const base::FilePath& download_directory,
+    const std::string& id,
     const base::Callback<void(const base::FilePath&)>& callback) {
   base::FilePath directory(g_download_directory_for_tests ?
-                     *g_download_directory_for_tests : download_directory);
+      *g_download_directory_for_tests : download_directory);
 
 #if defined(OS_CHROMEOS)
   // Do not use drive for extension downloads.
   if (drive::util::IsUnderDriveMountPoint(directory))
     directory = DownloadPrefs::GetDefaultDownloadDirectory();
 #endif
 
   // Ensure the download directory exists. TODO(asargent) - make this use
   // common code from the downloads system.
   if (!base::DirectoryExists(directory)) {
@@ skipping 18 matching lines @@
       file_util::GetUniquePathNumber(file, base::FilePath::StringType());
   if (uniquifier > 0) {
     file = file.InsertBeforeExtensionASCII(
         base::StringPrintf(" (%d)", uniquifier));
   }
 
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
                           base::Bind(callback, file));
 }
 
+bool UseSeparateWebstoreDownloadDirectory() {
+  const char kFieldTrial[] = "WebstoreDownloadDirectory";
+  const char kSeparateDirectoryUnderUDD[] = "SeparateDirectoryUnderUDD";
+
+  std::string field_trial_group =
+      base::FieldTrialList::FindFullName(kFieldTrial);
+  return field_trial_group == kSeparateDirectoryUnderUDD;
+}
+
 }  // namespace
 
 namespace extensions {
 
 // static
 GURL WebstoreInstaller::GetWebstoreInstallURL(
-    const std::string& extension_id, InstallSource source) {
+    const std::string& extension_id,
+    InstallSource source) {
   std::string install_source;
   switch (source) {
     case INSTALL_SOURCE_INLINE:
       install_source = kInlineInstallSource;
       break;
     case INSTALL_SOURCE_APP_LAUNCHER:
       install_source = kAppLauncherInstallSource;
       break;
     case INSTALL_SOURCE_OTHER:
       install_source = kDefaultInstallSource;
@@ skipping 340 matching lines @@
   CHECK(!pending_modules_.empty());
   if (pending_modules_.size() == 1) {
     DCHECK_EQ(id_, pending_modules_.front().extension_id);
     DownloadCrx(id_, install_source_);
   } else {
     DownloadCrx(pending_modules_.front().extension_id, INSTALL_SOURCE_OTHER);
   }
 }
 
 void WebstoreInstaller::DownloadCrx(
-    const std::string& extension_id, InstallSource source) {
+    const std::string& extension_id,
+    InstallSource source) {
   download_url_ = GetWebstoreInstallURL(extension_id, source);
-  base::FilePath download_path = DownloadPrefs::FromDownloadManager(
-      BrowserContext::GetDownloadManager(profile_))->DownloadPath();
+
+  base::FilePath download_path;
+  if (UseSeparateWebstoreDownloadDirectory()) {
+    base::FilePath user_data_dir;
+    PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
+    download_path = user_data_dir.Append(kWebstoreDownloadFolder);
+  } else {
+    download_path = DownloadPrefs::FromDownloadManager(
+        BrowserContext::GetDownloadManager(profile_))->DownloadPath();
+  }
+
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&GetDownloadFilePath, download_path, id_,
         base::Bind(&WebstoreInstaller::StartDownload, this)));
 }
 
 // http://crbug.com/165634
 // http://crbug.com/126013
 // The current working theory is that one of the many pointers dereferenced in
 // here is occasionally deleted before all of its referers are nullified,
@@ skipping 80 matching lines @@
 void WebstoreInstaller::ReportSuccess() {
   if (delegate_) {
     delegate_->OnExtensionInstallSuccess(id_);
     delegate_ = NULL;
   }
 
   Release();  // Balanced in Start().
 }
 
 }  // namespace extensions