Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: src/assembler.cc

Issue 46583006: Refactored EXTERNAL_REFERENCE handling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/assembler.h ('k') | src/disassembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 PrintF(out, "%p %s", pc_, RelocModeName(rmode_)); 812 PrintF(out, "%p %s", pc_, RelocModeName(rmode_));
813 if (IsComment(rmode_)) { 813 if (IsComment(rmode_)) {
814 PrintF(out, " (%s)", reinterpret_cast<char*>(data_)); 814 PrintF(out, " (%s)", reinterpret_cast<char*>(data_));
815 } else if (rmode_ == EMBEDDED_OBJECT) { 815 } else if (rmode_ == EMBEDDED_OBJECT) {
816 PrintF(out, " ("); 816 PrintF(out, " (");
817 target_object()->ShortPrint(out); 817 target_object()->ShortPrint(out);
818 PrintF(out, ")"); 818 PrintF(out, ")");
819 } else if (rmode_ == EXTERNAL_REFERENCE) { 819 } else if (rmode_ == EXTERNAL_REFERENCE) {
820 ExternalReferenceEncoder ref_encoder(isolate); 820 ExternalReferenceEncoder ref_encoder(isolate);
821 PrintF(out, " (%s) (%p)", 821 PrintF(out, " (%s) (%p)",
822 ref_encoder.NameOfAddress(*target_reference_address()), 822 ref_encoder.NameOfAddress(target_reference()),
823 *target_reference_address()); 823 target_reference());
824 } else if (IsCodeTarget(rmode_)) { 824 } else if (IsCodeTarget(rmode_)) {
825 Code* code = Code::GetCodeFromTargetAddress(target_address()); 825 Code* code = Code::GetCodeFromTargetAddress(target_address());
826 PrintF(out, " (%s) (%p)", Code::Kind2String(code->kind()), 826 PrintF(out, " (%s) (%p)", Code::Kind2String(code->kind()),
827 target_address()); 827 target_address());
828 if (rmode_ == CODE_TARGET_WITH_ID) { 828 if (rmode_ == CODE_TARGET_WITH_ID) {
829 PrintF(" (id=%d)", static_cast<int>(data_)); 829 PrintF(" (id=%d)", static_cast<int>(data_));
830 } 830 }
831 } else if (IsPosition(rmode_)) { 831 } else if (IsPosition(rmode_)) {
832 PrintF(out, " (%" V8_PTR_PREFIX "d)", data()); 832 PrintF(out, " (%" V8_PTR_PREFIX "d)", data());
833 } else if (IsRuntimeEntry(rmode_) && 833 } else if (IsRuntimeEntry(rmode_) &&
(...skipping 884 matching lines...) Expand 10 before | Expand all | Expand 10 after
1718 assembler_->RecordRelocInfo(RelocInfo::POSITION, state_.current_position); 1718 assembler_->RecordRelocInfo(RelocInfo::POSITION, state_.current_position);
1719 state_.written_position = state_.current_position; 1719 state_.written_position = state_.current_position;
1720 written = true; 1720 written = true;
1721 } 1721 }
1722 1722
1723 // Return whether something was written. 1723 // Return whether something was written.
1724 return written; 1724 return written;
1725 } 1725 }
1726 1726
1727 } } // namespace v8::internal 1727 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/disassembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698