Issue 46583006: Refactored EXTERNAL_REFERENCE handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46583006: Refactored EXTERNAL_REFERENCE handling. (Closed)

Created:
7 years, 1 month ago by Sven Panne

Modified:
7 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactored EXTERNAL_REFERENCE handling. Previously, the result of target_reference_address() could only be read, writing to it would have had an architecture-dependent effect, e.g. writing into the code on ia32, a no-op on arm, etc. This refactoring-only CL turns this into a simple getter, making it impossible to use incorrectly. More to come... R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17467

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -18 lines)			Patch
M	src/arm/assembler-arm-inl.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/assembler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/disassembler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/assembler-mips-inl.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/serialize.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r17467.

Expand Messages | Collapse Messages