Send Allow{Database,FileSystem,IndexedDB} sync IPCs directly from worker thread

chrome/renderer/in_renderer_worker_permission_client_proxy.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/render_messages.h"
+#include "chrome/renderer/in_renderer_worker_permission_client_proxy.h"
+#include "content/public/renderer/render_thread.h"
+#include "ipc/ipc_sync_message_filter.h"
+#include "third_party/WebKit/public/web/WebDocument.h"
+#include "third_party/WebKit/public/web/WebFrame.h"
+#include "third_party/WebKit/public/web/WebSecurityOrigin.h"
+
+InRendererWorkerPermissionClientProxy::InRendererWorkerPermissionClientProxy(
+    WebKit::WebFrame* frame,
+    int routing_id)
+    : routing_id_(routing_id),
+      is_unique_origin_(false) {
+  if (frame->document().securityOrigin().isUnique() ||
+      frame->top()->document().securityOrigin().isUnique())
+    is_unique_origin_ = true;
+  DCHECK(content::RenderThread::Get());

[jam, 2013/10/29 17:19:57]

nit: this isn't very useful, since in release builds it does nothing, and in
debug ones the next line is just as helpful to the developer

[kinuko, 2013/10/30 00:24:56]

Removed.

+  sync_message_filter_ = content::RenderThread::Get()->GetSyncMessageFilter();
+  document_origin_url_ = GURL(frame->document().securityOrigin().toString());
+  top_frame_origin_url_ = GURL(
+      frame->top()->document().securityOrigin().toString());
+}
+
+InRendererWorkerPermissionClientProxy::~InRendererWorkerPermissionClientProxy(
+    ) {}
+
+bool InRendererWorkerPermissionClientProxy::allowDatabase(
+    const WebKit::WebString& name,
+    const WebKit::WebString& display_name,
+    unsigned long estimated_size) {
+  if (is_unique_origin_ || !sync_message_filter_)

[jam, 2013/10/29 17:19:57]

nit: here and below, why is there the !sync_message_filter check? this should
always be non null

[kinuko, 2013/10/30 00:24:56]

Removed the check (here and below)

+    return false;
+
+  bool result = false;
+  sync_message_filter_->Send(new ChromeViewHostMsg_AllowDatabase(
+      routing_id_, document_origin_url_, top_frame_origin_url_,
+      name, display_name, &result));
+  return result;
+}
+
+bool InRendererWorkerPermissionClientProxy::allowFileSystem() {
+  if (is_unique_origin_ || !sync_message_filter_)
+    return false;
+
+  bool result = false;
+  sync_message_filter_->Send(new ChromeViewHostMsg_AllowFileSystem(
+      routing_id_, document_origin_url_, top_frame_origin_url_, &result));
+  return result;
+}
+
+bool InRendererWorkerPermissionClientProxy::allowIndexedDB(
+    const WebKit::WebString& name) {
+  if (is_unique_origin_ || !sync_message_filter_)
+    return false;
+
+  bool result = false;
+  sync_message_filter_->Send(new ChromeViewHostMsg_AllowIndexedDB(
+      routing_id_, document_origin_url_, top_frame_origin_url_, name, &result));
+  return result;
+}