Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 465823003: SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. Committed: https://skia.googlesource.com/skia/+/ea4673fde65f15d6f1ca77e24ced7348c4914517

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : fix ARGB/AGBR byte order bug (edit) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M gyp/core.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImage.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 3 chunks +13 lines, -0 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 2 2 chunks +41 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-12 14:46:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/465823003/1
6 years, 4 months ago (2014-08-12 14:46:25 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-12 14:46:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 14:46:29 UTC) #4
hal.canary
ptal
6 years, 4 months ago (2014-08-12 14:46:29 UTC) #5
commit-bot: I haz the power
Presubmit check for 465823003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-12 14:46:30 UTC) #6
reed1
lgtm https://codereview.chromium.org/465823003/diff/1/include/core/SkImage.h File include/core/SkImage.h (right): https://codereview.chromium.org/465823003/diff/1/include/core/SkImage.h#newcode57 include/core/SkImage.h:57: tiny nit: 2 lines blank?
6 years, 4 months ago (2014-08-12 14:49:04 UTC) #7
hal.canary
https://codereview.chromium.org/465823003/diff/1/include/core/SkImage.h File include/core/SkImage.h (right): https://codereview.chromium.org/465823003/diff/1/include/core/SkImage.h#newcode57 include/core/SkImage.h:57: On 2014/08/12 14:49:04, reed1 wrote: > tiny nit: 2 ...
6 years, 4 months ago (2014-08-12 14:55:19 UTC) #8
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-12 14:55:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/465823003/20001
6 years, 4 months ago (2014-08-12 14:56:30 UTC) #10
commit-bot: I haz the power
Change committed as 186f7b04956a1742f185a4ca69b44b52bc50e7fc
6 years, 4 months ago (2014-08-12 15:05:03 UTC) #11
hal.canary
A revert of this CL has been created in https://codereview.chromium.org/453723003/ by halcanary@google.com. The reason for ...
6 years, 4 months ago (2014-08-12 16:06:01 UTC) #12
hal.canary
Tests pass, ready to land after M38 branch.
6 years, 4 months ago (2014-08-14 13:56:57 UTC) #13
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-18 15:12:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/465823003/60001
6 years, 4 months ago (2014-08-18 15:12:18 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 15:27:13 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (60001) as ea4673fde65f15d6f1ca77e24ced7348c4914517

Powered by Google App Engine
This is Rietveld 408576698