Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: build/config/android/rules.gni

Issue 465713002: Add linting for java libraries/apks to gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lint-jar
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/android/internal_rules.gni") 6 import("//build/config/android/internal_rules.gni")
7 import("//tools/grit/grit_rule.gni") 7 import("//tools/grit/grit_rule.gni")
8 8
9 assert(is_android) 9 assert(is_android)
10 10
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 # This target creates an Android library containing java code and Android 398 # This target creates an Android library containing java code and Android
399 # resources. 399 # resources.
400 # 400 #
401 # Variables 401 # Variables
402 # deps: Specifies the dependencies of this target. Java targets in this list 402 # deps: Specifies the dependencies of this target. Java targets in this list
403 # will be added to the javac classpath. Android resources in dependencies 403 # will be added to the javac classpath. Android resources in dependencies
404 # will be used when building this library. 404 # will be used when building this library.
405 # java_files: List of .java files included in this library. 405 # java_files: List of .java files included in this library.
406 # srcjar_deps: List of srcjar dependencies. The .java files in the srcjars 406 # srcjar_deps: List of srcjar dependencies. The .java files in the srcjars
407 # will be added to java_files and be included in this library. 407 # will be added to java_files and be included in this library.
408 # 408 # chromium_code: If true, extra static analysis warning/errors will be enabled .
409 # jar_excluded_patterns: List of patterns of .class files to exclude from the 409 # jar_excluded_patterns: List of patterns of .class files to exclude from the
410 # final jar. 410 # final jar.
411 # 411 #
412 # Example 412 # Example
413 # android_library("foo_java") { 413 # android_library("foo_java") {
414 # java_files = [ 414 # java_files = [
415 # "android/org/chromium/foo/Foo.java", 415 # "android/org/chromium/foo/Foo.java",
416 # "android/org/chromium/foo/FooInterface.java", 416 # "android/org/chromium/foo/FooInterface.java",
417 # "android/org/chromium/foo/FooService.java", 417 # "android/org/chromium/foo/FooService.java",
418 # ] 418 # ]
(...skipping 18 matching lines...) Expand all
437 type = "android_library" 437 type = "android_library"
438 438
439 deps = [] 439 deps = []
440 if (defined(invoker.deps)) { 440 if (defined(invoker.deps)) {
441 deps += invoker.deps 441 deps += invoker.deps
442 } 442 }
443 443
444 # base_path 444 # base_path
445 } 445 }
446 446
447 _chromium_code = true
448 if (defined(invoker.chromium_code)) {
449 _chromium_code = invoker.chromium_code
450 }
451
447 android_java_library(target_name) { 452 android_java_library(target_name) {
453 chromium_code = _chromium_code
448 java_files = invoker.java_files 454 java_files = invoker.java_files
449 build_config = build_config 455 build_config = build_config
450 456
451 if (defined(invoker.jar_excluded_patterns)) { 457 if (defined(invoker.jar_excluded_patterns)) {
452 jar_excluded_patterns = invoker.jar_excluded_patterns 458 jar_excluded_patterns = invoker.jar_excluded_patterns
453 } 459 }
454 460
455 if (defined(invoker.srcjar_deps)) { 461 if (defined(invoker.srcjar_deps)) {
456 srcjar_deps = invoker.srcjar_deps 462 srcjar_deps = invoker.srcjar_deps
457 } 463 }
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 if (_enable_chromium_linker_tests) { 594 if (_enable_chromium_linker_tests) {
589 defines += ["ENABLE_CHROMIUM_LINKER_TESTS"] 595 defines += ["ENABLE_CHROMIUM_LINKER_TESTS"]
590 } 596 }
591 } 597 }
592 _srcjar_deps += [ ":${target_name}__native_libraries_java" ] 598 _srcjar_deps += [ ":${target_name}__native_libraries_java" ]
593 599
594 rebased_build_config = rebase_path(build_config, root_build_dir) 600 rebased_build_config = rebase_path(build_config, root_build_dir)
595 601
596 final_deps += [":${target_name}__java"] 602 final_deps += [":${target_name}__java"]
597 android_java_library("${target_name}__java") { 603 android_java_library("${target_name}__java") {
604 android_manifest = invoker.android_manifest
598 java_files = invoker.java_files 605 java_files = invoker.java_files
599 srcjar_deps = _srcjar_deps 606 srcjar_deps = _srcjar_deps
600 dex_path = base_path + ".dex.jar" 607 dex_path = base_path + ".dex.jar"
601 } 608 }
602 609
603 final_deps += [":${target_name}__final_dex"] 610 final_deps += [":${target_name}__final_dex"]
604 dex("${target_name}__final_dex") { 611 dex("${target_name}__final_dex") {
605 sources = [jar_path] 612 sources = [jar_path]
606 inputs = [build_config] 613 inputs = [build_config]
607 output = final_dex_path 614 output = final_dex_path
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 "//testing/android/java/src/org/chromium/native_test/ChromeNativeTestActiv ity.java" 696 "//testing/android/java/src/org/chromium/native_test/ChromeNativeTestActiv ity.java"
690 ] 697 ]
691 android_manifest = "//testing/android/java/AndroidManifest.xml" 698 android_manifest = "//testing/android/java/AndroidManifest.xml"
692 unittests_outputs = [ unittests_binary ] 699 unittests_outputs = [ unittests_binary ]
693 native_libs = [unittests_outputs[0]] 700 native_libs = [unittests_outputs[0]]
694 if (defined(invoker.deps)) { 701 if (defined(invoker.deps)) {
695 deps = invoker.deps 702 deps = invoker.deps
696 } 703 }
697 } 704 }
698 } 705 }
OLDNEW
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698