Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 465693002: GN: Remove duplicate entries from sources lists (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, haitaol+watch_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN: Remove duplicate entries from sources lists R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290688

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M printing/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
These are all pretty simple errors. My main motivation is to make it possible to ...
6 years, 4 months ago (2014-08-11 21:57:36 UTC) #1
jamesr
6 years, 4 months ago (2014-08-13 04:05:39 UTC) #2
brettw
lgtm
6 years, 4 months ago (2014-08-19 21:02:41 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-19 21:05:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/465693002/40001
6 years, 4 months ago (2014-08-19 21:06:02 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 23:00:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 23:04:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5353)
6 years, 4 months ago (2014-08-19 23:04:15 UTC) #8
jamesr
6 years, 4 months ago (2014-08-19 23:05:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as 290688.

Powered by Google App Engine
This is Rietveld 408576698