Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 465673002: Get rid of forcing the load stale cache UI experiment on canary and dev. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index f6553c3e8370a3fa1221f398a8862494add9d927..dcd507ca075dc96b835dce6e3dd2067e640f4966 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1278,12 +1278,12 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
}
{
- // Enable load stale cache if this session is in the field trial, one
- // of the forced on channels, or the user explicitly enabled it.
- // Note that as far as the renderer is concerned, the feature is
- // enabled if-and-only-if the kEnableOfflineLoadStaleCache flag
- // is on the command line; the yes/no/default behavior is only
- // at the browser command line level.
+ // Enable load stale cache if this session is in the field trial or
+ // the user explicitly enabled it. Note that as far as the renderer
+ // is concerned, the feature is enabled if-and-only-if the
+ // kEnableOfflineLoadStaleCache flag is on the command line;
+ // the yes/no/default behavior is only at the browser command line
+ // level.
// Command line switches override
if (browser_command_line.HasSwitch(
@@ -1293,17 +1293,8 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
switches::kDisableOfflineLoadStaleCache)) {
std::string group =
base::FieldTrialList::FindFullName("LoadStaleCacheExperiment");
- chrome::VersionInfo::Channel channel =
- chrome::VersionInfo::GetChannel();
-#if defined(OS_ANDROID) || defined(OS_IOS)
- chrome::VersionInfo::Channel force_channel =
- chrome::VersionInfo::CHANNEL_DEV;
-#else
- chrome::VersionInfo::Channel force_channel =
- chrome::VersionInfo::CHANNEL_CANARY;
-#endif
- if (channel <= force_channel || group == "Enabled")
+ if (group == "Enabled")
command_line->AppendSwitch(switches::kEnableOfflineLoadStaleCache);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698