Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 465633003: Updates state order of DiskBasedCertCache::WriteWorker. (Closed)

Created:
6 years, 4 months ago by brandonsalmon
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updates state order of DiskBasedCertCache::WriteWorker. It makes more sense to try to open the entries first rather than create them, since they will usually only not exist the first time. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M net/http/disk_based_cert_cache.cc View 6 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brandonsalmon
After thinking about it, it makes a lot more sense to actually try opening the ...
6 years, 4 months ago (2014-08-12 00:05:46 UTC) #1
rvargas (doing something else)
lgtm
6 years, 4 months ago (2014-08-12 02:02:10 UTC) #2
brandonsalmon
The CQ bit was checked by brandonsalmon@chromium.org
6 years, 4 months ago (2014-08-13 16:06:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brandonsalmon@chromium.org/465633003/1
6 years, 4 months ago (2014-08-13 16:08:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 289342
6 years, 4 months ago (2014-08-13 19:07:55 UTC) #5
wtc
6 years, 4 months ago (2014-08-15 01:19:45 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698