Factor Chrome details out of update manifest fetching.

chrome/browser/extensions/updater/extension_downloader.h

Index: chrome/browser/extensions/updater/extension_downloader.h
diff --git a/chrome/browser/extensions/updater/extension_downloader.h b/chrome/browser/extensions/updater/extension_downloader.h
index a0409866f17938dfcfb8bd9594de7fe2cfbce0b9..8cbd60f02a797951ea522d3ad8b676eebb4cd4c3 100644
--- a/chrome/browser/extensions/updater/extension_downloader.h
+++ b/chrome/browser/extensions/updater/extension_downloader.h
@@ -19,8 +19,8 @@
 #include "base/memory/weak_ptr.h"
 #include "base/version.h"
 #include "chrome/browser/extensions/updater/extension_downloader_delegate.h"
-#include "chrome/browser/extensions/updater/manifest_fetch_data.h"
 #include "chrome/browser/extensions/updater/request_queue.h"
+#include "extensions/browser/updater/manifest_fetch_data.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/update_manifest.h"
 #include "google_apis/gaia/oauth2_token_service.h"
@@ -100,6 +100,19 @@ class ExtensionDownloader
   void SetWebstoreIdentityProvider(
       scoped_ptr<IdentityProvider> identity_provider);
 
+  // Sets the brand code to use when sending ping data with manifest fetches.
+  void SetBrandCode(const std::string& brand_code);

[not at google - send to devlin, 2014/08/13 01:30:02]

Consider making these simpler set_brand_code methods to declare inline. All they
do is set properties verbatim.

+
+  // Sets base parameters to include with manifest fetch queries.
+  void SetManifestQueryParams(const std::string& params);
+
+  // Enable ping data to be sent for update URLs matching a given domain.
+  void EnablePingDataForDomain(const std::string& domain);
+
+  // Enable extra metrics to be included along with ping data. Currently this
+  // includes a flag indicating each extension's enabled/disabled state.
+  void EnableExtraUpdateMetrics(bool enable);
+
   // These are needed for unit testing, to help identify the correct mock
   // URLFetcher objects.
   static const int kManifestFetcherId = 1;
@@ -244,6 +257,9 @@ class ExtensionDownloader
   virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
                                  const GoogleServiceAuthError& error) OVERRIDE;
 
+  ManifestFetchData* CreateManifestFetchData(const GURL& update_url,
+                                             int request_id);
+
   // The delegate that receives the crx files downloaded by the
   // ExtensionDownloader, and that fills in optional ping and update url data.
   ExtensionDownloaderDelegate* delegate_;
@@ -291,6 +307,20 @@ class ExtensionDownloader
   // A pending token fetch request.
   scoped_ptr<OAuth2TokenService::Request> access_token_request_;
 
+  // Brand code to include with manifest fetch queries if sending ping data.
+  std::string brand_code_;
+
+  // Baseline parameters to include with manifest fetch queries.
+  std::string manifest_query_params_;
+
+  // Domain to enable ping data. Ping data will be sent with manifest fetches
+  // to update URLs which match this domain. Defaults to empty (no domain).
+  std::string ping_enabled_domain_;
+
+  // Indicates whether or not extra metrics should be included with ping data.
+  // Defaults to |false|.
+  bool enable_extra_update_metrics_;
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionDownloader);
 };