Issue 465503002: Fix FEConvolveMatrix bias issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465503002: Fix FEConvolveMatrix bias issue. (Closed)

Created:
6 years, 4 months ago by Stephen White

Modified:
6 years, 4 months ago

Reviewers:
f(malita)

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix FEConvolveMatrix bias issue. Skia's SkMatrixConvolutionImageFilter expects its "bias" parameter to be in pixel component scale (ie., 0 = none, 255 = full), whereas FEConvolveMatrix uses normalized scale. Scale by 255 to please Skia. BUG=402493 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179974

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	Source/platform/graphics/filters/FEConvolveMatrix.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/465503002/1

6 years, 4 months ago (2014-08-11 16:55:22 UTC) #3

Message was sent while issue was closed.

Change committed as 179974

Expand Messages | Collapse Messages