chrome/android/java/res/layout/distilled_page_prefs_view.xml - Issue 465493002: Font Size UI for Distilled Pages

Side by Side Diff: chrome/android/java/res/layout/distilled_page_prefs_view.xml

Issue 465493002: Font Size UI for Distilled Pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsView	8 <org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsView

9 xmlns:android="http://schemas.android.com/apk/res/android"	9 xmlns:android="http://schemas.android.com/apk/res/android"

10 android:layout_width="match_parent"	10 android:layout_width="match_parent"

11 android:layout_height="wrap_content"	11 android:layout_height="wrap_content"

12 android:orientation="horizontal"	12 android:orientation="vertical"

13 android:background="@drawable/distilled_page_pref_background"	13 android:background="@drawable/distilled_page_pref_background"

	14 android:splitMotionEvents="false"
	newt (away) 2014/08/11 17:15:30 Just curious: why does this need to be false? Just curious: why does this need to be false? smaslo 2014/08/12 02:25:43 Done. On 2014/08/11 17:15:30, newt wrote: Done. On 2014/08/11 17:15:30, newt wrote: Show quoted text > Just curious: why does this need to be false?
14 android:padding="10dp" >	15 android:padding="10dp" >

15	16

16 <RadioButton	17 <RadioGroup

17 android:id="@+id/light_mode"	18 android:layout_width="match_parent"

18 android:text="@string/light_mode"	19 android:id="@+id/radio_button_group"
	newt (away) 2014/08/11 17:15:30 put id before layout_width put id before layout_width smaslo 2014/08/12 02:25:44 Done. Show quoted text On 2014/08/11 17:15:30, newt wrote: > put id before layout_width Done.
19 style="@style/DistilledPagePrefThemeButton" />	20 android:layout_height="wrap_content"

	21 android:orientation="horizontal" >

20	22

21 <RadioButton	23 <RadioButton

22 android:id="@+id/dark_mode"	24 android:id="@+id/light_mode"

23 android:text="@string/dark_mode"	25 android:text="@string/light_mode"

24 style="@style/DistilledPagePrefThemeButton" />	26 style="@style/DistilledPagePrefThemeButton" />

25	27

26 <RadioButton	28 <RadioButton

27 android:id="@+id/sepia_mode"	29 android:id="@+id/dark_mode"

28 android:text="@string/sepia_mode"	30 android:text="@string/dark_mode"

29 style="@style/DistilledPagePrefThemeButton" />	31 style="@style/DistilledPagePrefThemeButton" />

	32 <RadioButton

	33 android:id="@+id/sepia_mode"

	34 android:text="@string/sepia_mode"

	35 style="@style/DistilledPagePrefThemeButton" />

	36

	37 </RadioGroup>

	38 <LinearLayout

	39 android:layout_width="match_parent"

	40 android:layout_height="wrap_content"

	41 android:orientation="horizontal"

	42 android:layout_marginTop="3dp">

	43

	44 <TextView

	45 android:id="@+id/font_size_percentage"
	newt (away) 2014/08/11 17:15:30 Setting "sp" units in the width is a bit unusual. Setting "sp" units in the width is a bit unusual. We'd typically use a minWidth and some padding/margin in a case like this. Does that work for you? smaslo 2014/08/12 02:25:43 Done. Show quoted text On 2014/08/11 17:15:30, newt wrote: > Setting "sp" units in the width is a bit unusual. We'd typically use a minWidth > and some padding/margin in a case like this. Does that work for you? Done.
	46 android:layout_width="60sp"

	47 android:layout_height="match_parent"

	48 android:orientation="horizontal"
	newt (away) 2014/08/11 17:15:30 "orientation" doesn't apply to TextView, or any of "orientation" doesn't apply to TextView, or any of the views below. These should all be removed. smaslo 2014/08/12 02:25:43 Done. Show quoted text On 2014/08/11 17:15:30, newt wrote: > "orientation" doesn't apply to TextView, or any of the views below. These should > all be removed. Done.
	49 android:gravity="center"

	50 android:textSize="17sp" />

	51

	52 <TextView

	53 android:layout_width="wrap_content"

	54 android:layout_height="match_parent"

	55 android:orientation="horizontal"

	56 android:gravity="center"
	newt (away) 2014/08/11 17:15:30 Use center_vertical to be more explicit with your Use center_vertical to be more explicit with your intentions. Same below. smaslo 2014/08/12 02:25:43 Done. Show quoted text On 2014/08/11 17:15:30, newt wrote: > Use center_vertical to be more explicit with your intentions. Same below. Done.
	57 android:layout_marginStart="5dp"

	58 android:textSize="13sp"

	59 android:text="A" />
	newt (away) 2014/08/11 17:15:30 I suspect that different letters would be appropri I suspect that different letters would be appropriate for users in other locales. You should add a string to chrome_android_strings.grd and use that here (and below), so that it can be localized. smaslo 2014/08/12 02:25:43 Done. Show quoted text On 2014/08/11 17:15:30, newt wrote: > I suspect that different letters would be appropriate for users in other > locales. You should add a string to chrome_android_strings.grd and use that here > (and below), so that it can be localized. Done.
	60

	61 <SeekBar

	62 android:id="@+id/font_size"

	63 android:layout_width="0dp"

	64 android:layout_height="wrap_content"

	65 android:layout_weight="4"
	newt (away) 2014/08/11 17:15:30 Just use layout_weight="1". It's equivalent and do Just use layout_weight="1". It's equivalent and doesn't leave the reader wondering, why the number "4"? smaslo 2014/08/12 02:25:43 Done. Show quoted text On 2014/08/11 17:15:30, newt wrote: > Just use layout_weight="1". It's equivalent and doesn't leave the reader > wondering, why the number "4"? Done.
	66 android:orientation="horizontal"

	67 android:max="30" />

	68

	69 <TextView

	70 android:layout_width="wrap_content"

	71 android:layout_height="match_parent"

	72 android:orientation="horizontal"

	73 android:gravity="center"

	74 android:layout_marginEnd="3dp"

	75 android:textSize="20sp"

	76 android:text="A" />

	77

	78 </LinearLayout>

	79

30 </org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsView>	80 </org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsView>

OLD	NEW