Initial implementation of ServiceWorkerCache.

net/base/io_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_IO_BUFFER_H_
 #define NET_BASE_IO_BUFFER_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
@@ skipping 97 matching lines @@
 
   int size_;
 };
 
 // This is a read only IOBuffer.  The data is stored in a string and
 // the IOBuffer interface does not provide a proper way to modify it.
 class NET_EXPORT StringIOBuffer : public IOBuffer {
  public:
   explicit StringIOBuffer(const std::string& s);
 
+  // The string passed to this constructor is std::string::swap'd with the

[michaeln, 2014/08/21 01:46:15]

Given the scoped_ptr<> input, the xfer of ownership of the string is clear and
the swap method usage is an impl detail. Consider removing the comment
altogether?

[jkarlin, 2014/08/21 18:31:21]

Done.

+  // internal string. This is a low cost way to prevent a copy for strings that
+  // don't provide copy-on-write semantics.
+  explicit StringIOBuffer(scoped_ptr<std::string> s);
+
   int size() const { return static_cast<int>(string_data_.size()); }
 
  private:
   virtual ~StringIOBuffer();
 
   std::string string_data_;
 };
 
 // This version wraps an existing IOBuffer and provides convenient functions
 // to progressively read all the data.
@@ skipping 107 matching lines @@
  public:
   explicit WrappedIOBuffer(const char* data);
 
  protected:
   virtual ~WrappedIOBuffer();
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_IO_BUFFER_H_