Certificate Transparency: Use component updater for EV whitelist

Certificate Transparency: Use component updater for EV whitelist

Fetches the list of EV certificate hashes using the component updater.
Once this is in, we could gather data on how many EV certificates do
not appear in any Certificate Transparency log.

BUG=339128
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289001

[Eran Messeri, 2014-08-11 15:01:43]

Sorin/Joshua - as requested, I've separated the files related to the component
updater to a separate CL. Can one of you take a look?

[waffles, 2014-08-11 20:23:13]

lgtm, through I don't know much about the histograms.

[Sorin Jianu, 2014-08-12 00:37:52]

lgtm

Thank you Eran!

https://codereview.chromium.org/465443002/diff/60001/chrome/browser/component...
File chrome/browser/component_updater/ev_whitelist_component_installer.cc
(right):

https://codereview.chromium.org/465443002/diff/60001/chrome/browser/component...
chrome/browser/component_updater/ev_whitelist_component_installer.cc:97: return
compressed_whitelist.size() > 0;
Consider return !compressed_whitelist.empty()?

empty() is the idiomatic way to test for the no items condition.

[Eran Messeri, 2014-08-12 09:52:08]

Thanks for the quick review! Addressed review comments, adding jochen for OWNERS
approval of chrome/browser/chrome_browser_main.cc

https://codereview.chromium.org/465443002/diff/60001/chrome/browser/component...
File chrome/browser/component_updater/ev_whitelist_component_installer.cc
(right):

https://codereview.chromium.org/465443002/diff/60001/chrome/browser/component...
chrome/browser/component_updater/ev_whitelist_component_installer.cc:97: return
compressed_whitelist.size() > 0;
On 2014/08/12 00:37:52, Sorin Jianu wrote:
> Consider return !compressed_whitelist.empty()?
> 
> empty() is the idiomatic way to test for the no items condition.

Done.

[Eran Messeri, 2014-08-12 09:55:07]

Changed reviewers to thestig@ as he's reviewed past Certificate
Transparency-related CL. Lei, LMK if you'd like me to nominate another reviewer.

[jochen (gone - plz use gerrit), 2014-08-12 10:05:52]

lgtm

[Eran Messeri, 2014-08-12 13:17:06]

The CQ bit was checked by eranm@chromium.org

[commit-bot: I haz the power, 2014-08-12 13:18:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eranm@chromium.org/465443002/100001

[commit-bot: I haz the power, 2014-08-12 16:26:25]

Change committed as 289001