Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: chrome/browser/policy/cloud/cloud_policy_invalidator.cc

Issue 465433002: Separate UMA histograms for user and device policy invalidation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/cloud_policy_invalidator.cc
diff --git a/chrome/browser/policy/cloud/cloud_policy_invalidator.cc b/chrome/browser/policy/cloud/cloud_policy_invalidator.cc
index 6ba5047fb736b43e146f1c96a9b217b556c7d7de..b177396e1753c8f8057c49d7898c0f80b988a7e3 100644
--- a/chrome/browser/policy/cloud/cloud_policy_invalidator.cc
+++ b/chrome/browser/policy/cloud/cloud_policy_invalidator.cc
@@ -31,10 +31,12 @@ const int CloudPolicyInvalidator::kUnknownVersionIgnorePeriod = 30;
const int CloudPolicyInvalidator::kMaxInvalidationTimeDelta = 300;
CloudPolicyInvalidator::CloudPolicyInvalidator(
+ bool handling_user_policy,
CloudPolicyCore* core,
const scoped_refptr<base::SequencedTaskRunner>& task_runner,
scoped_ptr<base::Clock> clock)
: state_(UNINITIALIZED),
+ handling_user_policy_(handling_user_policy),
core_(core),
task_runner_(task_runner),
clock_(clock.Pass()),
@@ -141,11 +143,16 @@ void CloudPolicyInvalidator::OnStoreLoaded(CloudPolicyStore* store) {
bool policy_changed = IsPolicyChanged(store->policy());
if (is_registered_) {
- // Update the kMetricPolicyRefresh histogram.
- UMA_HISTOGRAM_ENUMERATION(
- kMetricPolicyRefresh,
- GetPolicyRefreshMetric(policy_changed),
- METRIC_POLICY_REFRESH_SIZE);
+ // Update the kMetricUserPolicyRefresh/kMetricDevicePolicyRefresh histogram.
+ if (handling_user_policy_) {
+ UMA_HISTOGRAM_ENUMERATION(kMetricUserPolicyRefresh,
+ GetPolicyRefreshMetric(policy_changed),
+ METRIC_POLICY_REFRESH_SIZE);
+ } else {
+ UMA_HISTOGRAM_ENUMERATION(kMetricDevicePolicyRefresh,
+ GetPolicyRefreshMetric(policy_changed),
+ METRIC_POLICY_REFRESH_SIZE);
+ }
// If the policy was invalid and the version stored matches the latest
// invalidation version, acknowledge the latest invalidation.
@@ -189,10 +196,18 @@ void CloudPolicyInvalidator::HandleInvalidation(
// Ignore the invalidation if it is expired.
bool is_expired = IsInvalidationExpired(version);
- UMA_HISTOGRAM_ENUMERATION(
- kMetricPolicyInvalidations,
- GetInvalidationMetric(payload.empty(), is_expired),
- POLICY_INVALIDATION_TYPE_SIZE);
+
+ if (handling_user_policy_) {
+ UMA_HISTOGRAM_ENUMERATION(
+ kMetricUserPolicyInvalidations,
+ GetInvalidationMetric(payload.empty(), is_expired),
+ POLICY_INVALIDATION_TYPE_SIZE);
+ } else {
+ UMA_HISTOGRAM_ENUMERATION(
+ kMetricDevicePolicyInvalidations,
+ GetInvalidationMetric(payload.empty(), is_expired),
+ POLICY_INVALIDATION_TYPE_SIZE);
+ }
if (is_expired) {
invalidation.Acknowledge();
return;

Powered by Google App Engine
This is Rietveld 408576698