Separate UMA histograms for user and device policy invalidation

chrome/browser/policy/cloud/cloud_policy_invalidator.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_
 #define CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
+#include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
 #include "components/invalidation/invalidation.h"
 #include "components/invalidation/invalidation_handler.h"
 #include "components/policy/core/common/cloud/cloud_policy_core.h"
 #include "components/policy/core/common/cloud/cloud_policy_store.h"
 #include "google/cacheinvalidation/include/types.h"
 
@@ skipping 27 matching lines @@
   static const int kInvalidationGracePeriod;
 
   // Time, in seconds, for which unknown version invalidations are ignored after
   // fetching a policy.
   static const int kUnknownVersionIgnorePeriod;
 
   // The max tolerated discrepancy, in seconds, between policy timestamps and
   // invalidation timestamps when determining if an invalidation is expired.
   static const int kMaxInvalidationTimeDelta;
 
+  // |handling_user_policy| indicates whether this invalidator is responsible
+  // for user policy (as opposed to device policy).
   // |core| is the cloud policy core which connects the various policy objects.
   // It must remain valid until Shutdown is called.
   // |task_runner| is used for scheduling delayed tasks. It must post tasks to
   // the main policy thread.
   // |clock| is used to get the current time.
   CloudPolicyInvalidator(
+      bool handling_user_policy,

[Joao da Silva, 2014/08/11 13:21:27]

WDYT of using enterprise_management::DeviceRegisterRequest::Type instead of a
bool?

The call site would be more obvious (new
CloudPolicyInvalidator(em::DeviceRegisterRequest::DEVICE), vs USER or BROWSER or
etc).

[bartfab (slow), 2014/08/11 14:01:59]

Done.

       CloudPolicyCore* core,
       const scoped_refptr<base::SequencedTaskRunner>& task_runner,
       scoped_ptr<base::Clock> clock);
   virtual ~CloudPolicyInvalidator();
 
   // Initializes the invalidator. No invalidations will be generated before this
   // method is called. This method must only be called once.
   // |invalidation_service| is the invalidation service to use and must remain
   // valid until Shutdown is called.
   void Initialize(invalidation::InvalidationService* invalidation_service);
@@ skipping 74 matching lines @@
 
   // The state of the object.
   enum State {
     UNINITIALIZED,
     STOPPED,
     STARTED,
     SHUT_DOWN
   };
   State state_;
 
+  // Whether this invalidator is responsible for user policy.
+  const bool handling_user_policy_;
+
   // The cloud policy core.
   CloudPolicyCore* core_;
 
   // Schedules delayed tasks.
   const scoped_refptr<base::SequencedTaskRunner> task_runner_;
 
   // The clock.
   scoped_ptr<base::Clock> clock_;
 
   // The invalidation service.
@@ skipping 48 matching lines @@
   // A thread checker to make sure that callbacks are invoked on the correct
   // thread.
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(CloudPolicyInvalidator);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_