Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: tests_lit/llvm2ice_tests/align-spill-locations.ll

Issue 465413003: Subzero: Align spill locations to natural alignment. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Patch Set: LocalsSizeBytes -> SpillAreaSizeBytes, local variables -> allocas Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests_lit/llvm2ice_tests/align-spill-locations.ll
diff --git a/tests_lit/llvm2ice_tests/align-spill-locations.ll b/tests_lit/llvm2ice_tests/align-spill-locations.ll
new file mode 100644
index 0000000000000000000000000000000000000000..4db7eb19a5d93e3b803a0e98825113dce11ee88d
--- /dev/null
+++ b/tests_lit/llvm2ice_tests/align-spill-locations.ll
@@ -0,0 +1,90 @@
+; This checks to ensure that Subzero aligns spill slots.
+
+; RUN: %llvm2ice --verbose none %s | FileCheck %s
+; RUN: %llvm2ice -O2 --verbose none %s | FileCheck %s
+; RUN: %llvm2ice --verbose none %s | FileCheck --check-prefix=ERRORS %s
+
+; The location of the stack slot for a variable is inferred from the
+; return sequence.
+
+; In this file, "global" refers to a variable with a live range across
+; multiple basic blocks (not an LLVM global variable) and "local"
+; refers to a variable that is live in only a single basic block.
+
+define <4 x i32> @align_global_vector(i32 %arg) {
+entry:
+ %vec.global = insertelement <4 x i32> undef, i32 %arg, i32 0
+ br label %block
+block:
+ call void @ForceXmmSpills()
+ ret <4 x i32> %vec.global
+; CHECK-LABEL: align_global_vector:
+; CHECK: movups xmm0, xmmword ptr [esp]
+; CHECK-NEXT: add esp, 28
+; CHECK-NEXT: ret
+}
+
+define <4 x i32> @align_local_vector(i32 %arg) {
+entry:
+ br label %block
+block:
+ %vec.local = insertelement <4 x i32> undef, i32 %arg, i32 0
+ call void @ForceXmmSpills()
+ ret <4 x i32> %vec.local
+; CHECK-LABEL: align_local_vector:
+; CHECK: movups xmm0, xmmword ptr [esp]
+; CHECK-NEXT: add esp, 28
+; CHECK-NEXT: ret
+}
+
+declare void @ForceXmmSpills()
+
+define <4 x i32> @align_global_vector_ebp_based(i32 %arg) {
+entry:
+ %alloc = alloca i8, i32 1, align 1
+ %vec.global = insertelement <4 x i32> undef, i32 %arg, i32 0
+ br label %block
+block:
+ call void @ForceXmmSpillsAndUseAlloca(i8* %alloc)
+ ret <4 x i32> %vec.global
+; CHECK-LABEL: align_global_vector_ebp_based:
+; CHECK: movups xmm0, xmmword ptr [ebp-24]
+; CHECK-NEXT: mov esp, ebp
+; CHECK-NEXT: pop ebp
+; CHECK: ret
+}
+
+define <4 x i32> @align_local_vector_ebp_based(i32 %arg) {
+entry:
+ %alloc = alloca i8, i32 1, align 1
+ %vec.local = insertelement <4 x i32> undef, i32 %arg, i32 0
+ call void @ForceXmmSpillsAndUseAlloca(i8* %alloc)
+ ret <4 x i32> %vec.local
+; CHECK-LABEL: align_local_vector_ebp_based:
+; CHECK: movups xmm0, xmmword ptr [ebp-24]
+; CHECK-NEXT: mov esp, ebp
+; CHECK-NEXT: pop ebp
+; CHECK: ret
+}
+
+define <4 x i32> @align_local_vector_and_global_float(i32 %arg) {
+entry:
+ %float.global = sitofp i32 %arg to float
+ call void @ForceXmmSpillsAndUseFloat(float %float.global)
+ br label %block
+block:
+ %vec.local = insertelement <4 x i32> undef, i32 undef, i32 0
+ call void @ForceXmmSpillsAndUseFloat(float %float.global)
+ ret <4 x i32> %vec.local
+; CHECK-LABEL: align_local_vector_and_global_float:
+; CHECK: cvtsi2ss xmm0, eax
+; CHECK-NEXT: movss dword ptr [esp+28], xmm0
+; CHECK: movups xmm0, xmmword ptr [esp]
+; CHECK-NEXT: add esp, 44
+; CHECK-NEXT: ret
+}
+
+declare void @ForceXmmSpillsAndUseAlloca(i8*)
+declare void @ForceXmmSpillsAndUseFloat(float)
+
+; ERRORS-NOT: ICE translation error
« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698