Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/chromeos/policy/enrollment_handler_chromeos.h

Issue 465413002: Minor cleanup of EnrollmentHandlerChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation for AMD64 Chromium OS. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
diff --git a/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h b/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
index 275aa2b27bcdbd56e36b18e36d1cd2ac7ae6c04e..71bd5fae5f181d5ad23963c75f8f071347c03e1f 100644
--- a/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
+++ b/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
@@ -121,35 +121,34 @@ class EnrollmentHandlerChromeOS : public CloudPolicyClient::Observer,
};
// Handles the response to a request for server-backed state keys.
- void CheckStateKeys(const std::vector<std::string>& state_keys,
- bool first_boot);
+ void HandleStateKeysResult(const std::vector<std::string>& state_keys,
+ bool first_boot);
// Starts registration if the store is initialized.
- void AttemptRegistration();
+ void StartRegistration();
- // Handles the policy validation result, proceeding with installation-time
- // attributes locking if successful.
- void PolicyValidated(DeviceCloudPolicyValidator* validator);
+ // Handles the policy validation result, proceeding with device lock if
+ // successful.
+ void HandlePolicyValidationResult(DeviceCloudPolicyValidator* validator);
- // Calls LockDevice() and proceeds to policy installation. If unsuccessful,
- // reports the result. Actual installation or error report will be done in
- // HandleLockDeviceResult().
+ // Calls InstallAttributes::LockDevice() for enterprise enrollment and
+ // DeviceSettingsService::SetManagementSettings() for consumer
+ // enrollment.
void StartLockDevice();
// Checks the status after SetManagementSettings() is done. Proceeds to
// robot auth code storing if successful.
- void OnSetManagementSettingsDone();
+ void HandleSetManagementSettingsDone();
- // Helper for StartLockDevice(). It performs the actual action based on
- // the result of LockDevice.
+ // Handle callback from InstallAttributes::LockDevice() and retry on failure.
void HandleLockDeviceResult(
EnterpriseInstallAttributes::LockResult lock_result);
- // Stores robot auth token.
- void StoreRobotAuth();
+ // Initiates storing of robot auth token.
+ void StartStoreRobotAuth();
// Handles completion of the robot token store operation.
- void HandleRobotAuthTokenStored(bool result);
+ void HandleStoreRobotAuthTokenResult(bool result);
// Drops any ongoing actions.
void Stop();

Powered by Google App Engine
This is Rietveld 408576698