Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: tools/findit/common/utils.py

Issue 465403004: [Findit] Support sending cookies for http requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nit. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/findit/common/utils.py
diff --git a/tools/findit/utils.py b/tools/findit/common/utils.py
similarity index 77%
rename from tools/findit/utils.py
rename to tools/findit/common/utils.py
index 4e8a0ab947c28e74887dca6732af763f4f0eb59b..363048c0796fac54225b6fd8b8c3884166ad9d4b 100644
--- a/tools/findit/utils.py
+++ b/tools/findit/common/utils.py
@@ -5,6 +5,8 @@
import re
import sys
+from http_client_local import HttpClientLocal
+
GIT_HASH_PATTERN = re.compile(r'^[0-9a-fA-F]{40}$')
@@ -22,3 +24,8 @@ def GetOSName(platform_name=sys.platform):
def IsGitHash(revision):
return GIT_HASH_PATTERN.match(str(revision))
+
+
+def GetHttpClient():
+ # TODO(stgao): return implementation for appengine when running on appengine.
Martin Barbella 2014/08/15 23:00:02 Are two implementations necessary? Isn't setting C
stgao 2014/08/15 23:11:03 Yes, we need two different implementation. On appe
+ return HttpClientLocal

Powered by Google App Engine
This is Rietveld 408576698