[Findit] Support sending cookies for http requests.

tools/findit/https.py

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

[aarya, 2014/08/15 05:29:23]

Please rename this file to connection_handler or http_handler. https is a pretty
bad name for this file.

[stgao, 2014/08/15 06:49:49]

This is more than connection_handler or http_handler.
Maybe rename to http_client?

 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """
 Provides a utility function for https connections with certificate verification.
 
 The verification is based on http://tools.ietf.org/html/rfc6125#section-6.4.3
 and the code is from Lib/ssl.py in python3:
   http://hg.python.org/cpython/file/4dac45f88d45/Lib/ssl.py
 
 One use case is to download Chromium DEPS file in a secure way:
   https://src.chromium.org/chrome/trunk/src/DEPS
 
 Notice: python 2.7 or newer is required.
 """
 
+import cookielib
 import httplib
 import os
 import re
 import socket
 import ssl
 import urllib2
 
 
 _SCRIPT_DIR = os.path.dirname(__file__)
 _TRUSTED_ROOT_CERTS = os.path.join(_SCRIPT_DIR, 'cacert.pem')
@@ skipping 153 matching lines @@
   Returns:
     A string that is the response from the server.
 
   Raises:
     ValueError: Unexpected value is received during certificate verification.
     CertificateError: Certificate verification fails.
   """
   if not https_url or not https_url.startswith('https://'):
     raise ValueError('Not a https request for url %s.' % str(https_url))
 
-  url_opener = urllib2.build_opener(HTTPSHandler)
+  handlers = [HTTPSHandler()]
+  cookie_file = os.environ.get('COOKIE_FILE')
+  if cookie_file and os.path.exists(cookie_file):
+    handlers.append(
+        urllib2.HTTPCookieProcessor(cookielib.MozillaCookieJar(cookie_file)))
+
+  url_opener = urllib2.build_opener(*handlers)
   return url_opener.open(https_url).read()
 
 
 if __name__ == '__main__':

[aarya, 2014/08/15 05:29:23]

Please remove this test __main__ code.

[stgao, 2014/08/15 06:49:49]

What's the reason to remove this code?
It is for testing.

   print SendRequest('https://src.chromium.org/chrome/trunk/src/DEPS')