Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 465393002: Add show_home_button value to reset feedback reports (Closed)

Created:
6 years, 4 months ago by battre
Modified:
6 years, 4 months ago
Reviewers:
vasilii
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add show_home_button value to reset feedback reports BUG=235037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/profile_resetter/resettable_settings_snapshot.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/profile_resetter/resettable_settings_snapshot.cc View 5 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
battre
Hi Vasilii, could you please review this CL? Thanks, Dominic
6 years, 4 months ago (2014-08-13 14:44:02 UTC) #1
vasilii
lgtm
6 years, 4 months ago (2014-08-13 15:03:24 UTC) #2
battre
The CQ bit was checked by battre@chromium.org
6 years, 4 months ago (2014-08-13 15:30:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/465393002/1
6 years, 4 months ago (2014-08-13 15:31:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 16:43:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 17:15:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1309)
6 years, 4 months ago (2014-08-13 17:15:27 UTC) #7
battre
The CQ bit was checked by battre@chromium.org
6 years, 4 months ago (2014-08-14 07:12:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/465393002/1
6 years, 4 months ago (2014-08-14 07:14:30 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 08:44:32 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (1) as 289494

Powered by Google App Engine
This is Rietveld 408576698