Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 465363004: Use the gtest_main target for test executables (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Use the gtest_main target for test executables. There’s no need to build a separate copy of gtest_main.cc for each test executable. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7090b209adbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M minidump/minidump.gyp View 1 chunk +1 line, -1 line 0 comments Download
M util/util.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-13 19:30:35 UTC) #1
Mark Mentovai
6 years, 4 months ago (2014-08-13 19:33:03 UTC) #2
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-13 19:54:19 UTC) #3
Mark Mentovai
6 years, 4 months ago (2014-08-13 22:29:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 7090b209adbf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698