Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 465333005: Gallery.app: Handles readonly volumes. (Closed)

Created:
6 years, 4 months ago by hirono
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery.app: Handles readonly volumes. The CL handles read only volumes and lets Gallery * disable rename input box. * show a warning message about the save directory of image edit. BUG=403749 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290217

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : Rebase and fixed. #

Patch Set 5 : Reupload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -22 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 1 2 3 4 10 chunks +39 lines, -13 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 7 chunks +24 lines, -7 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
hirono
The CL handles read only volumes and lets Gallery * disable rename input box. * ...
6 years, 4 months ago (2014-08-15 03:32:52 UTC) #1
hirono
PTAL the CL? The CL depends on crrev.com/470983002. Thank you!
6 years, 4 months ago (2014-08-15 03:33:36 UTC) #2
yoshiki
lgtm https://codereview.chromium.org/465333005/diff/40001/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/465333005/diff/40001/ui/file_manager/gallery/js/gallery.js#newcode216 ui/file_manager/gallery/js/gallery.js:216: console.error(error); Please show a short description of the ...
6 years, 4 months ago (2014-08-15 03:37:15 UTC) #3
hirono
https://codereview.chromium.org/465333005/diff/40001/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/465333005/diff/40001/ui/file_manager/gallery/js/gallery.js#newcode216 ui/file_manager/gallery/js/gallery.js:216: console.error(error); On 2014/08/15 03:37:14, yoshiki wrote: > Please show ...
6 years, 4 months ago (2014-08-15 08:04:16 UTC) #4
yoshiki
still lgtm
6 years, 4 months ago (2014-08-15 08:24:14 UTC) #5
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-16 04:53:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/465333005/60001
6 years, 4 months ago (2014-08-16 04:54:44 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-16 05:07:28 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 05:09:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/42662) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/6331) ios_rel_device ...
6 years, 4 months ago (2014-08-16 05:09:01 UTC) #10
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-18 05:04:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/465333005/80001
6 years, 4 months ago (2014-08-18 05:05:04 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 07:36:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (80001) as 290217

Powered by Google App Engine
This is Rietveld 408576698