Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 465333004: Non-composited, fixed position should trigger main thread scrolling (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, kenneth.christiansen, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Non-composited, fixed position should trigger main thread scrolling In a recent change, I broke the logic for determining whether fixed position elements should trigger main thread scrolling. This CL fixes the logic to trigger main thread scrolling if we have fixed position elements that lack composited layers. R=vollick@chromium.org BUG=402359 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180226

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
A + LayoutTests/compositing/layer-creation/main-thread-scrolling-for-non-composited-fixed-position.html View 3 chunks +3 lines, -11 lines 0 comments Download
A + LayoutTests/compositing/layer-creation/main-thread-scrolling-for-non-composited-fixed-position-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 1 chunk +17 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-13 22:05:30 UTC) #1
Ian Vollick
lgtm. https://codereview.chromium.org/465333004/diff/1/Source/core/page/scrolling/ScrollingCoordinator.cpp File Source/core/page/scrolling/ScrollingCoordinator.cpp (right): https://codereview.chromium.org/465333004/diff/1/Source/core/page/scrolling/ScrollingCoordinator.cpp#newcode894 Source/core/page/scrolling/ScrollingCoordinator.cpp:894: // Whether the RenderLayer scrolls wth the viewport ...
6 years, 4 months ago (2014-08-13 22:22:00 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-13 23:06:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/465333004/20001
6 years, 4 months ago (2014-08-13 23:07:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-14 03:09:46 UTC) #5
abarth-chromium
6 years, 4 months ago (2014-08-14 03:49:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as 180226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698