Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 465333003: Close a loophole in extension content verification (Closed)

Created:
6 years, 4 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Close a loophole in extension content verification If you both deleted the computed_hashes.json and modified the verified_contents.json so that the signature failed, we'd never fix it. This patch changes things so that we validate the verified_contents.json instead of just assuming that the file existing means it's contents are ok. BUG=402727 R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289567

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M extensions/browser/content_hash_fetcher.cc View 1 7 chunks +36 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
asargent_no_longer_on_chrome
(still working on a unit test for this, but wanted to get the change in ...
6 years, 4 months ago (2014-08-13 23:10:28 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 4 months ago (2014-08-14 04:50:36 UTC) #2
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 4 months ago (2014-08-14 05:26:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/465333003/40001
6 years, 4 months ago (2014-08-14 05:28:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 11:33:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 12:02:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/4168)
6 years, 4 months ago (2014-08-14 12:02:45 UTC) #7
asargent_no_longer_on_chrome
6 years, 4 months ago (2014-08-14 14:42:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as 289567 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698