Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Issue 465313002: Reduces DVLOG overhead in PulseAudioInputStream for Linux (Closed)

Created:
6 years, 4 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reduces DVLOG overhead in PulseAudioInputStream for Linux. The existing DVLOG creates a huge amount of log output when using a */media/*=1 filter. TBR=xians1 BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M media/audio/pulse/pulse_input.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
henrika (OOO until Aug 14)
We see this today in most WebRTC clients: [13109:13131:0813/131910:VERBOSE1:pulse_input.cc(292)] OnData is being called consecutively, sleep ...
6 years, 4 months ago (2014-08-13 11:32:35 UTC) #1
xians
lgtm
6 years, 4 months ago (2014-08-13 11:55:36 UTC) #2
henrika (OOO until Aug 14)
6 years, 4 months ago (2014-08-13 12:50:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 289274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698