Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 465283003: libvpx.gyp: Fix process_outputs_as_sources usage. (Closed)

Created:
6 years, 4 months ago by Tom Finegan
Modified:
6 years, 4 months ago
CC:
chromium-reviews, wwcv, jzern, fgalligan1
Visibility:
Public.

Description

libvpx.gyp: Fix process_outputs_as_sources usage. Replace three instances of 'process_output_as_sources' with 'process_outputs_as_sources'. Note that one of these is from an include. R=fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289332

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M libvpx.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M unpack_lib_posix.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Finegan
6 years, 4 months ago (2014-08-13 17:46:29 UTC) #1
Ami GONE FROM CHROMIUM
I don't really understand this stuff anymore, sorry :( https://codereview.chromium.org/465283003/diff/1/libvpx.gyp File libvpx.gyp (right): https://codereview.chromium.org/465283003/diff/1/libvpx.gyp#newcode482 libvpx.gyp:482: ...
6 years, 4 months ago (2014-08-13 17:56:49 UTC) #2
Tom Finegan
Comments, and added another one that I missed (thanks Johann). Thanks, Ami-- I can leave ...
6 years, 4 months ago (2014-08-13 18:06:48 UTC) #3
Ami GONE FROM CHROMIUM
LGTM
6 years, 4 months ago (2014-08-13 18:33:46 UTC) #4
Tom Finegan
6 years, 4 months ago (2014-08-13 18:34:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r289332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698