Issue 465273002: Remove RegExp.$input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465273002: Remove RegExp.$input. (Closed)

Created:
6 years, 4 months ago by Yang

Modified:
6 years, 4 months ago

Reviewers:
mathiasb, arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -4 lines)			Patch
M	src/regexp.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/mjsunit/string-match.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Yang

On 2014/08/13 09:40:39, Yang wrote: Note: I won't land this until after the 3.29 branch.

6 years, 4 months ago (2014-08-13 10:33:47 UTC) #2

Yang

Committed patchset #1 manually as 23223 (presubmit successful).

6 years, 4 months ago (2014-08-20 09:43:09 UTC) #5

mathiasb

6 years, 4 months ago (2014-08-25 07:46:20 UTC) #6

Message was sent while issue was closed.

Ah, missed this stray comment during review:
https://codereview.chromium.org/503703002