Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 465223005: [Android] Turn heap_profiler_unittests into an apk and reenable them. (Closed)

Created:
6 years, 4 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
Yaron, jbudorick, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, navabi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Turn heap_profiler_unittests into an apk and reenable them. heap_profiler_unittests was previously a native executable target. It turns out that we don't have the harness in place to run native executable tests reliably on all Android versions due to the PIE vs non-PIE issue (L vs ICS, see crbug.com/373219). This caused a revert in crrev.com/416003005. This change is making heap_profiler_unittests an apk target, following the same pattern of the other tests we have in the codebase. This change is also re-adding the tests to the the bot list. BUG=393964 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291197

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move to EXPERIMENTAL_TEST_SUITES #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M build/all.gyp View 2 chunks +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler.gyp View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Primiano Tucci (use gerrit)
+jbudorick for one line change reenabling the test +yfriedman for the gyp changes in tools/android
6 years, 4 months ago (2014-08-19 10:43:48 UTC) #1
Yaron
https://codereview.chromium.org/465223005/diff/1/build/android/pylib/gtest/gtest_config.py File build/android/pylib/gtest/gtest_config.py (right): https://codereview.chromium.org/465223005/diff/1/build/android/pylib/gtest/gtest_config.py#newcode9 build/android/pylib/gtest/gtest_config.py:9: 'content_gl_tests', start here, make sure it works, then move ...
6 years, 4 months ago (2014-08-19 18:23:04 UTC) #2
Primiano Tucci (use gerrit)
https://codereview.chromium.org/465223005/diff/1/build/android/pylib/gtest/gtest_config.py File build/android/pylib/gtest/gtest_config.py (right): https://codereview.chromium.org/465223005/diff/1/build/android/pylib/gtest/gtest_config.py#newcode9 build/android/pylib/gtest/gtest_config.py:9: 'content_gl_tests', On 2014/08/19 18:23:04, Yaron wrote: > start here, ...
6 years, 4 months ago (2014-08-20 10:15:20 UTC) #3
Yaron
lgtm
6 years, 4 months ago (2014-08-20 17:31:50 UTC) #4
Sami
lgtm
6 years, 4 months ago (2014-08-21 13:00:49 UTC) #5
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 4 months ago (2014-08-21 13:50:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/465223005/20001
6 years, 4 months ago (2014-08-21 13:51:51 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:35:54 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 291197

Powered by Google App Engine
This is Rietveld 408576698