[ Do not submit ] Prototype for invalidation analysis

Source/core/rendering/GraphicsContextAnnotator.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 15 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/rendering/GraphicsContextAnnotator.h"
 
 #include "core/inspector/InspectorNodeIds.h"
+#include "core/inspector/InspectorTraceEvents.h"
 #include "core/rendering/PaintInfo.h"
 #include "core/rendering/RenderObject.h"
 #include "platform/graphics/GraphicsContextAnnotation.h"
 #include "wtf/text/StringBuilder.h"
 
 namespace {
 
 const char AnnotationKeyRendererName[]    = "RENDERER";
 const char AnnotationKeyPaintPhase[]      = "PHASE";
 const char AnnotationKeyElementId[]       = "ID";
@@ skipping 33 matching lines @@
     default:
         ASSERT_NOT_REACHED();
         return "<unknown>";
     }
 }
 
 }
 
 namespace blink {
 
+// FIXME: Introduce a real paint API instead of piggybacking on GraphicsContextAnnotator.
+void GraphicsContextAnnotator::trackPaintInvalidation(const PaintInfo&, RenderObject* renderer)
+{
+    TRACE_EVENT_INSTANT1(
+        TRACE_DISABLED_BY_DEFAULT("devtools.timeline.paintInvalidationTracking"),
+        "PaintInvalidationTracking",
+        "data",
+        InspectorPaintInvalidationTrackingEvent::data(renderer));

[caseq, 2014/08/26 12:19:07]

Why do we need this? We already have nodeId in the annotation...

+}
+
 void GraphicsContextAnnotator::annotate(const PaintInfo& paintInfo, const RenderObject* object)
 {
     ASSERT(!m_context);
 
     ASSERT(paintInfo.context);
     ASSERT(object);
 
     AnnotationList annotations;
     AnnotationModeFlags mode = paintInfo.context->annotationMode();
     Element* element = object->node() && object->node()->isElementNode() ? toElement(object->node()) : 0;
@@ skipping 35 matching lines @@
     m_context->beginAnnotation(annotations);
 }
 
 void GraphicsContextAnnotator::finishAnnotation()
 {
     ASSERT(m_context);
     m_context->endAnnotation();
 }
 
 } // namespace blink