Issue 465133005: pdf: Early out from CopyImage if there's nothing to copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465133005: pdf: Early out from CopyImage if there's nothing to copy. (Closed)

Created:
6 years, 4 months ago by sadrul

Modified:
6 years, 4 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

pdf: Early out from CopyImage if there's nothing to copy. If CopyImage is called with src is an empty rectangle (this can happen for example if one of the resources is not available), then the code ends up trying to read from null/uninitialized memory. So early out instead in such cases. BUG=401242 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290736

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pdf/draw_utils.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 4 months ago (2014-08-20 02:45:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 290736 (presubmit successful).

Expand Messages | Collapse Messages