Remove DenyCertForHost from SSLHostStateDelegate API.

chrome/browser/ssl/chrome_ssl_host_state_delegate.h

Index: chrome/browser/ssl/chrome_ssl_host_state_delegate.h
diff --git a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
index 1353c20020a5b958d91d33779bd037cc6e25f1bc..44e97c56a3145679a6f0030768828fceeba60fed 100644
--- a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
+++ b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
@@ -18,19 +18,16 @@ class DictionaryValue;
 }  //  namespace base
 
 // Implementation of the tracking of user decisions on SSL errors for sites.
-// Tracks if the user has allowed, denied, or not seen an exception for the
-// specified site, SSL fingerprint, and error. If the user makes a decision,
-// stores the decision until either the session ends or for a length of time
-// (across session restarts), based on command line flags.
+// Tracks if the user has allowed or has not seen an exception for the specified
+// site, SSL fingerprint, and error. If the user makes a decision, stores the
+// decision until either the session ends or for a length of time (across
+// session restarts), based on command line flags.

[Peter Kasting, 2014/08/22 00:57:52]

Nit: How about this comment:

Tracks whether the user has allowed a certificate error exception for a specific
site, SSL fingerprint, and error.  Based on command-line flags, remembers this
decision either until end-of-session or for a particular length of time.

[jww, 2014/08/22 03:49:35]

Done, with slight addition of "...and experimental group..."

 class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
  public:
   explicit ChromeSSLHostStateDelegate(Profile* profile);
   virtual ~ChromeSSLHostStateDelegate();
 
   // SSLHostStateDelegate:
-  virtual void DenyCert(const std::string& host,
-                        net::X509Certificate* cert,
-                        net::CertStatus error) OVERRIDE;
   virtual void AllowCert(const std::string& host,
                          net::X509Certificate* cert,
                          net::CertStatus error) OVERRIDE;
@@ -53,9 +50,9 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
   virtual void RevokeUserDecisions(const std::string& host);
   virtual void RevokeUserDecisionsHard(const std::string& host);
 
-  // Returns true if any decisions has been recorded for |host| for the given
-  // Profile, otherwise false.
-  virtual bool HasUserDecision(const std::string& host);
+  // Returns true if the user has allowed any certificate error exceptions for
+  // |host|, otherwise false.

[Peter Kasting, 2014/08/22 00:57:53]

Nit: How about:

Returns whether the user has allowed a certificate error exception for |host|.

[jww, 2014/08/22 03:49:35]

Done.

+  virtual bool HasAllowed(const std::string& host);
 
   // Called on the UI thread when the profile is about to be destroyed.
   void ShutdownOnUIThread() {}
@@ -88,18 +85,9 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
     RememberSSLExceptionDecisionsForDelta
   };
 
-  // Modify the user's content settings to specify a judgement made for a
-  // specific site and certificate, where |url| is the site in question, |cert|
-  // is the certificate with an error, |error| is the error in the certificate,
-  // and |judgement| is the user decision to be recorded.
-  void ChangeCertPolicy(const std::string& host,
-                        net::X509Certificate* cert,
-                        net::CertStatus error,
-                        net::CertPolicy::Judgment judgment);
-
   // Query the content settings to retrieve a dictionary of certificate

[Peter Kasting, 2014/08/22 00:57:52]

Nit: Same sorts of comments as above.

[jww, 2014/08/22 03:49:35]

Done.

-  // fingerprints and errors of certificates to user decisions, as set by
-  // ChangeCertPolicy. Returns NULL on a failure.
+  // fingerprints and errors of certificates to user decisions. Returns NULL on
+  // a failure.
   //
   // |dict| specifies the user's full exceptions dictionary for a specific site
   // in their content settings. Must be retrieved directly from a website