Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 465133003: Adds Chromecast hardware information to SystemProfileProto. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds Chromecast hardware information to SystemProfileProto. This information is already being collected and stored in UMA, but has been kept internal. Updating public proto to match the internal proto. R=isherman@chromium.org,asvitkine@chromium.org,ghines@chromium.org CC=lcwu@chromium.org BUG=400925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -0 lines) Patch
M components/metrics/proto/system_profile.proto View 1 chunk +152 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gunsch
6 years, 4 months ago (2014-08-13 20:20:56 UTC) #1
Alexei Svitkine (slow)
LGTM assuming it's the exact same content as the internal version.
6 years, 4 months ago (2014-08-14 15:28:32 UTC) #2
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-15 17:01:46 UTC) #3
gunsch
On 2014/08/14 15:28:32, Alexei Svitkine wrote: > LGTM assuming it's the exact same content as ...
6 years, 4 months ago (2014-08-15 17:02:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/465133003/1
6 years, 4 months ago (2014-08-15 17:03:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 19:37:07 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 21:25:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 290012

Powered by Google App Engine
This is Rietveld 408576698