Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 465113003: Chrome OS wallpaper manager. (Closed)

Created:
6 years, 4 months ago by hshi1
Modified:
6 years, 4 months ago
Reviewers:
garykac1, bshe, garykac
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Chrome OS wallpaper manager. Rename transparentBackground -> alphaEnabled and set corresponding permissions. This is in response to r288983. BUG=403166 TEST=verify wallpaper picker works on Chrome OS. R=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289316

Patch Set 1 #

Patch Set 2 : Fix Javascript style violation that is totally unrelated to my change. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/manifest.json View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
hshi1
PTAL this fixes the Chrome OS wallpaper manager.
6 years, 4 months ago (2014-08-13 01:38:29 UTC) #1
bshe
On 2014/08/13 01:38:29, hshi1 wrote: > PTAL this fixes the Chrome OS wallpaper manager. lgtm. ...
6 years, 4 months ago (2014-08-13 11:19:02 UTC) #2
hshi1
The CQ bit was checked by hshi@chromium.org
6 years, 4 months ago (2014-08-13 15:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/465113003/1
6 years, 4 months ago (2014-08-13 15:02:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 15:48:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 15:52:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3959)
6 years, 4 months ago (2014-08-13 15:52:18 UTC) #7
hshi1
The CQ bit was checked by hshi@chromium.org
6 years, 4 months ago (2014-08-13 16:22:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/465113003/20001
6 years, 4 months ago (2014-08-13 16:23:23 UTC) #9
hshi1
Committed patchset #2 manually as 289316 (presubmit successful).
6 years, 4 months ago (2014-08-13 16:32:25 UTC) #10
garykac1
6 years, 4 months ago (2014-08-13 17:21:29 UTC) #11
Message was sent while issue was closed. 
lgtm.

Thanks for fixing this.

https://codereview.chromium.org/465113003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/wallpaper_manager/manifest.json (right):

https://codereview.chromium.org/465113003/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/wallpaper_manager/manifest.json:16:
"experimental",
Previously, transparentBackground required 'experimental' permission, but now
that it has a separate permission you should no longer need it (unless you're
using another experimental feature).

Powered by Google App Engine
This is Rietveld 408576698