Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: util/misc/initialization_state_dcheck_test.cc

Issue 465103002: Add InitializationStateDcheck, its base class, and their tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Improve naming Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/misc/initialization_state_dcheck.cc ('k') | util/misc/initialization_state_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/misc/initialization_state_dcheck_test.cc
diff --git a/util/misc/initialization_state_dcheck_test.cc b/util/misc/initialization_state_dcheck_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..57a4e54a2bd48ccbaa8ac2b51e20026ea63a3fdc
--- /dev/null
+++ b/util/misc/initialization_state_dcheck_test.cc
@@ -0,0 +1,128 @@
+// Copyright 2014 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/misc/initialization_state_dcheck.h"
+
+#include "base/logging.h"
+#include "gtest/gtest.h"
+
+namespace {
+
+using namespace crashpad;
+
+TEST(InitializationStateDcheck, InitializationStateDcheck) {
+ InitializationStateDcheck initialization_state_dcheck;
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck);
+ INITIALIZATION_STATE_SET_VALID(initialization_state_dcheck);
+ INITIALIZATION_STATE_DCHECK_VALID(initialization_state_dcheck);
+}
+
+#if DCHECK_IS_ON
+
+// InitializationStateDcheck only DCHECKs, so the death tests can only run
+// when DCHECKs are enabled.
+
+TEST(InitializationStateDcheckDeathTest, Uninitialized_NotInvalid) {
+ // This tests that an attempt to set an uninitialized object as valid without
+ // transitioning through the initializing (invalid) state fails.
+ InitializationStateDcheck initialization_state_dcheck;
+ ASSERT_DEATH(INITIALIZATION_STATE_SET_VALID(initialization_state_dcheck),
+ "kStateInvalid");
+}
+
+TEST(InitializationStateDcheckDeathTest, Uninitialized_NotValid) {
+ // This tests that an attempt to use an uninitialized object as though it
+ // were valid fails.
+ InitializationStateDcheck initialization_state_dcheck;
+ ASSERT_DEATH(INITIALIZATION_STATE_DCHECK_VALID(initialization_state_dcheck),
+ "kStateValid");
+}
+
+TEST(InitializationStateDcheckDeathTest, Invalid_NotUninitialized) {
+ // This tests that an attempt to begin initializing an object on which
+ // initialization was already attempted fails.
+ InitializationStateDcheck initialization_state_dcheck;
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck);
+ ASSERT_DEATH(
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck),
+ "kStateUninitialized");
+}
+
+TEST(InitializationStateDcheckDeathTest, Invalid_NotValid) {
+ // This tests that an attempt to use an initializing object as though it
+ // were valid fails.
+ InitializationStateDcheck initialization_state_dcheck;
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck);
+ ASSERT_DEATH(INITIALIZATION_STATE_DCHECK_VALID(initialization_state_dcheck),
+ "kStateValid");
+}
+
+TEST(InitializationStateDcheckDeathTest, Valid_NotUninitialized) {
+ // This tests that an attempt to begin initializing an object that has already
+ // been initialized fails.
+ InitializationStateDcheck initialization_state_dcheck;
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck);
+ INITIALIZATION_STATE_SET_VALID(initialization_state_dcheck);
+ ASSERT_DEATH(
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck),
+ "kStateUninitialized");
+}
+
+TEST(InitializationStateDcheckDeathTest, Valid_NotInvalid) {
+ // This tests that an attempt to set a valid object as valid a second time
+ // fails.
+ InitializationStateDcheck initialization_state_dcheck;
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck);
+ INITIALIZATION_STATE_SET_VALID(initialization_state_dcheck);
+ ASSERT_DEATH(INITIALIZATION_STATE_SET_VALID(initialization_state_dcheck),
+ "kStateInvalid");
+}
+
+TEST(InitializationStateDcheckDeathTest, Destroyed_NotUninitialized) {
+ // This tests that an attempt to reinitialize a destroyed object fails. See
+ // the InitializationState.InitializationState test for an explanation of this
+ // use-after-free test.
+ InitializationStateDcheck* initialization_state_dcheck_pointer;
+ {
+ InitializationStateDcheck initialization_state_dcheck;
+ initialization_state_dcheck_pointer = &initialization_state_dcheck;
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck);
+ INITIALIZATION_STATE_SET_VALID(initialization_state_dcheck);
+ INITIALIZATION_STATE_DCHECK_VALID(initialization_state_dcheck);
+ }
+ ASSERT_DEATH(INITIALIZATION_STATE_SET_INITIALIZING(
+ *initialization_state_dcheck_pointer),
+ "kStateUninitialized");
+}
+
+TEST(InitializationStateDcheckDeathTest, Destroyed_NotValid) {
+ // This tests that an attempt to use a destroyed object fails. See the
+ // InitializationState.InitializationState test for an explanation of this
+ // use-after-free test.
+ InitializationStateDcheck* initialization_state_dcheck_pointer;
+ {
+ InitializationStateDcheck initialization_state_dcheck;
+ initialization_state_dcheck_pointer = &initialization_state_dcheck;
+ INITIALIZATION_STATE_SET_INITIALIZING(initialization_state_dcheck);
+ INITIALIZATION_STATE_SET_VALID(initialization_state_dcheck);
+ INITIALIZATION_STATE_DCHECK_VALID(initialization_state_dcheck);
+ }
+ ASSERT_DEATH(
+ INITIALIZATION_STATE_DCHECK_VALID(*initialization_state_dcheck_pointer),
+ "kStateValid");
+}
+
+#endif
+
+} // namespace
« no previous file with comments | « util/misc/initialization_state_dcheck.cc ('k') | util/misc/initialization_state_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698