Issue 465093002: Fix net import in ct-sheriff-o-matic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465093002: Fix net import in ct-sheriff-o-matic (Closed)

Created:
6 years, 4 months ago by leviw_travelin_and_unemployed

Modified:
6 years, 4 months ago

Reviewers:
ojan

CC:
ojan, blink-reviews, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix net import in ct-sheriff-o-matic I broke sheriff-o-matic by not updating the link to scripts/net.js when I transitioned it to lib/net.html. Updating fixes the UI. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180116

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Tools/GardeningServer/ui/ct-sheriff-o-matic.html	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/465093002/diff/1/Tools/GardeningServer/ui/ct-sheriff-o-matic.html File Tools/GardeningServer/ui/ct-sheriff-o-matic.html (right): https://codereview.chromium.org/465093002/diff/1/Tools/GardeningServer/ui/ct-sheriff-o-matic.html#newcode12 Tools/GardeningServer/ui/ct-sheriff-o-matic.html:12: <link rel="import" href="../lib/net.html"> As we discussed in person, ...

6 years, 4 months ago (2014-08-12 22:56:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/465093002/1

6 years, 4 months ago (2014-08-12 22:57:24 UTC) #3

Message was sent while issue was closed.

Change committed as 180116

Expand Messages | Collapse Messages