Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 465083004: PDF: Add a quick note regarding zoom factors in the OOP JS code. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
raymes
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

PDF: Add a quick note regarding zoom factors in the OOP JS code. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290720

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chrome_page_zoom_constants.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/viewport.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-19 22:26:01 UTC) #1
raymes
lgtm https://codereview.chromium.org/465083004/diff/20001/chrome/browser/chrome_page_zoom_constants.cc File chrome/browser/chrome_page_zoom_constants.cc (right): https://codereview.chromium.org/465083004/diff/20001/chrome/browser/chrome_page_zoom_constants.cc#newcode10 chrome/browser/chrome_page_zoom_constants.cc:10: // make sure the two matches. nit: "two ...
6 years, 4 months ago (2014-08-20 00:52:59 UTC) #2
Lei Zhang
https://codereview.chromium.org/465083004/diff/20001/chrome/browser/chrome_page_zoom_constants.cc File chrome/browser/chrome_page_zoom_constants.cc (right): https://codereview.chromium.org/465083004/diff/20001/chrome/browser/chrome_page_zoom_constants.cc#newcode10 chrome/browser/chrome_page_zoom_constants.cc:10: // make sure the two matches. On 2014/08/20 00:52:58, ...
6 years, 4 months ago (2014-08-20 00:55:46 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-20 00:55:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/465083004/40001
6 years, 4 months ago (2014-08-20 00:56:36 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 00:57:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (40001) as 290720

Powered by Google App Engine
This is Rietveld 408576698