Issue 465083003: Don't leak the shader in PatchBench.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465083003: Don't leak the shader in PatchBench. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
dandov, mtklein, tfarina

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Don't leak the shader in PatchBench. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e556be7084e43c64ca9d0df1b9c8ce16a988006f

Patch Set 2 : this-> #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
	M	bench/PatchBench.cpp	View	1	9 chunks	+20 lines, -20 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/465083003/20001

6 years, 4 months ago (2014-08-13 16:23:06 UTC) #3

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

6 years, 4 months ago (2014-08-13 16:23:07 UTC) #4

tfarina

https://codereview.chromium.org/465083003/diff/20001/bench/PatchBench.cpp File bench/PatchBench.cpp (right): https://codereview.chromium.org/465083003/diff/20001/bench/PatchBench.cpp#newcode120 bench/PatchBench.cpp:120: fPaint.setShader(this->createShader())->unref(); lgtm

6 years, 4 months ago (2014-08-13 16:54:33 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-13 17:41:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as e556be7084e43c64ca9d0df1b9c8ce16a988006f

Expand Messages | Collapse Messages

Issue 465083003: Don't leak the shader in PatchBench. (Closed)

Description

Patch Set 1 #

Patch Set 2 : this-> #

Messages