Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 465078: Add stubs for NPN_PopUpContextMenu and NPN_ConvertPoint (Closed)

Created:
11 years ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add stubs for NPN_PopUpContextMenu and NPN_ConvertPoint We claim to support the version of NPAPI that includes these functions, so we at least need to stub them out to prevent crashes. Real implementations and test cases for them will follow later. BUG=29454, 29457, 28002 TEST=Right click in Flash using a ToT Chromium build with the 10.1 Flash preview installed; it should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M webkit/glue/plugins/nphostapi.h View 2 chunks +11 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stuartmorgan
11 years ago (2009-12-04 23:59:31 UTC) #1
jam
11 years ago (2009-12-05 00:03:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698