Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5636)

Unified Diff: chrome_frame/crash_reporting/crash_report.cc

Issue 465074: Added support for running reliability tests for ChromeFrame on similar lines ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame_reporting.cc ('k') | chrome_frame/test/chrome_frame_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/crash_reporting/crash_report.cc
===================================================================
--- chrome_frame/crash_reporting/crash_report.cc (revision 34059)
+++ chrome_frame/crash_reporting/crash_report.cc (working copy)
@@ -1,3 +1,4 @@
+
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,10 +11,13 @@
#include "breakpad/src/client/windows/handler/exception_handler.h"
#include "chrome_frame/crash_reporting/vectored_handler.h"
#include "chrome_frame/crash_reporting/vectored_handler-impl.h"
+#include "chrome_frame/utils.h"
namespace {
// TODO(joshia): factor out common code with chrome used for crash reporting
const wchar_t kGoogleUpdatePipeName[] = L"\\\\.\\pipe\\GoogleCrashServices\\";
+const wchar_t kChromePipeName[] = L"\\\\.\\pipe\\ChromeCrashServices";
+
google_breakpad::ExceptionHandler* g_breakpad = NULL;
__declspec(naked)
@@ -56,6 +60,15 @@
extern "C" IMAGE_DOS_HEADER __ImageBase;
+std::wstring GetCrashServerPipeName(const std::wstring& user_sid) {
+ if (IsHeadlessMode())
+ return kChromePipeName;
+
+ std::wstring pipe_name = kGoogleUpdatePipeName;
+ pipe_name += user_sid;
+ return pipe_name;
+}
+
bool InitializeVectoredCrashReporting(
bool full_dump,
const wchar_t* user_sid,
@@ -66,8 +79,7 @@
if (g_breakpad)
return true;
- std::wstring pipe_name(kGoogleUpdatePipeName);
- pipe_name += user_sid;
+ std::wstring pipe_name = GetCrashServerPipeName(user_sid);
if (dump_path.empty()) {
return false;
« no previous file with comments | « chrome_frame/chrome_frame_reporting.cc ('k') | chrome_frame/test/chrome_frame_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698